Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference/configuration, faq: add both config and faq of server-version (#2144) #2269

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 14, 2020

cherry-pick #2144 to release-4.0


What is changed, added or deleted? (Required)

  • add config of server-version.
  • add faq of server-version.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

…on (pingcap#2144)

* reference/configuration, faq: add both config and faq of server-version

* Apply suggestions from code review

Co-Authored-By: reafans <30926443+reafans@users.noreply.github.com>

* address comment

* Update reference/configuration/tidb-server/configuration-file.md

Co-authored-by: reafans <30926443+reafans@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
@sre-bot sre-bot added status/require-change Needs the author to address comments. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Apr 14, 2020
@sre-bot sre-bot requested review from reafans and yikeke April 14, 2020 06:13
@TomShawn TomShawn merged commit ee4414e into pingcap:release-4.0 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/require-change Needs the author to address comments. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants