Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #21951

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

dveeden and others added 7 commits November 13, 2025 03:03
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot added lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 13, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces minor but important updates to the certificate-authentication.md documentation. The changes primarily focus on improving the clarity, accuracy, and consistency of the guide for configuring certificate authentication in TiDB. This includes removing unnecessary shortcodes, standardizing command syntax, correcting descriptions for certificate requirements, and adding a crucial command for reloading TLS configurations, making the documentation more precise and user-friendly.

Highlights

  • Documentation Cleanup: Removed redundant {{< copyable >}} shortcodes from various code blocks (bash, SQL, TOML) to streamline the markdown and improve readability.
  • Casing Standardization: Standardized the casing of REQUIRE clauses (e.g., require ssl to REQUIRE SSL, require issuer to REQUIRE ISSUER) for consistency in certificate configuration documentation.
  • Clarified REQUIRE CIPHER Description: Updated the description for REQUIRE CIPHER to accurately reflect that it checks the connection's cipher, rather than the client certificate's subject information.
  • TLS Reload Command Added: Included the ALTER INSTANCE RELOAD TLS; command in the server key rotation steps, providing a clear instruction for reloading TLS configurations.
  • Command Formatting Improvements: Adjusted spacing in mysql client connection commands (e.g., mysql -utest to mysql -u test) for improved clarity and consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several beneficial updates to the certificate authentication documentation. The removal of copyable shortcodes, standardization of keyword casing to uppercase (e.g., REQUIRE), and improved formatting in code blocks all enhance the document's clarity and consistency. The correction to the REQUIRE CIPHER description and the more detailed instructions for reloading server certificates are particularly helpful. I have one suggestion to correct a file path in a command to ensure it aligns with the steps described in the document.

@hfxsd
Copy link
Collaborator

hfxsd commented Nov 13, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2025
@ti-chi-bot ti-chi-bot bot merged commit 7fedce7 into pingcap:release-8.5 Nov 13, 2025
9 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-21951-to-release-8.5 branch November 13, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants