Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #21962

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

qiancai and others added 14 commits November 3, 2025 06:40
  Synced from: pingcap/docs-cn#20703
  Target PR: pingcap#21962
  AI Provider: gemini

  Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: you06 <you1474600@gmail.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@ti-chi-bot ti-chi-bot added for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. labels Nov 3, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation for TiDB's Follower Read feature. It provides clearer explanations of its purpose, implementation mechanisms, and configuration options, including new platform-specific details for replica selection and updated guidance on the tidb_replica_read system variable. The updates also introduce new monitoring metrics and discuss performance considerations, aiming to improve user understanding and effective utilization of Follower Read.

Highlights

  • Enhanced Follower Read Documentation: The follower-read.md document has been significantly updated to provide more comprehensive details on the Follower Read feature, including its purpose, implementation, and configuration.
  • Platform-Specific Replica Selection Details: New CustomContent blocks have been added to explain how TiDB selects appropriate replicas based on zone labels for both TiDB (self-managed) and TiDB Cloud environments, enhancing clarity for different deployment types.
  • New Usage Scenarios and Goals: The document now includes dedicated sections outlining suitable usage scenarios for Follower Read and its achieved goals, such as distributing read hotspots and prioritizing local replica reads.
  • Updated tidb_replica_read Variable Explanation: The tidb_replica_read system variable documentation has been revised to include recommended configurations (leader, closest-adaptive, closest-replicas) for reducing cross-AZ traffic, along with a compatibility note for versions v8.5.4 and v9.0.0.
  • Detailed Replica Selection Strategies: The 'Implementation mechanism' section now elaborates on specific follower replica selection strategies: leader, closest-replicas, and closest-adaptive, including their behaviors and implications.
  • Follower Read Performance Overhead: A new section has been added to discuss the performance overhead of Follower Read, particularly for small queries, and provides recommendations for its optimal use.
  • Monitoring Guidance: A 'Basic monitoring' section has been introduced, guiding users to the 'KV Request > Read Req Traffic' panel in Grafana for observing Follower Read effects, with platform-specific links.
  • New Grafana Metrics: The grafana-tidb-dashboard.md file has been updated to include new 'Read Req Traffic' metrics, providing more granular visibility into read request distribution (leader/follower, local/cross-zone).
  • tidb_replica_read Scope Clarification: The system-variables.md document now clarifies that the tidb_replica_read variable only affects read-only SQL statements starting from v8.5.4 and v9.0.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the Follower Read feature. I've reviewed the changes and made a few suggestions to improve grammar, clarity, and consistency, following the repository's style guide. The changes mostly involve minor wording improvements for better readability and a correction in the grafana-tidb-dashboard.md file to ensure metric descriptions are consistent.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai changed the title reference: update doc for follower read (#21962) Do not merge until v8.5.4: reference: update doc for follower read (#21962) Nov 4, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 4, 2025

@you06: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai changed the base branch from release-8.5 to feature/preview-v8.5.4 November 7, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants