Skip to content

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 7, 2020

What is changed, added or deleted? (Required)

Add TiFlash performance tuning document.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-3.1 labels Apr 7, 2020
@TomShawn TomShawn requested review from ilovesoup and yikeke April 7, 2020 12:39
@yikeke yikeke requested a review from ran-huang April 7, 2020 13:04
@yikeke
Copy link
Contributor

yikeke commented Apr 7, 2020

Please help review this PR. @ran-huang

@TomShawn
Copy link
Contributor Author

TomShawn commented Apr 8, 2020

@ran-huang PTAL again, thanks!

Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Co-Authored-By: Ran <huangran@pingcap.com>
@TomShawn
Copy link
Contributor Author

TomShawn commented Apr 9, 2020

@ilovesoup PTAL, thanks!

Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit c92a763 into pingcap:master Apr 9, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

cherry pick to release-3.1 in PR #2233

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

cherry pick to release-4.0 in PR #2234

@TomShawn TomShawn deleted the tiflash-tune branch April 10, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants