Add restriction for IMPORT INTO regarding empty (#20562) #20906
Conversation
- Added a new restriction to the IMPORT INTO documentation specifying that the target table must be entirely empty for import operations, including all partitions.
ti-chi-bot
added
lgtm
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a restriction to the IMPORT INTO statement in the TiDB documentation. Specifically, it clarifies that IMPORT INTO does not support importing data into an empty partition if other partitions of the same table already contain data. The target table must be completely empty for import operations. This change applies to the master branch and versions 9.0, 8.5, 8.4, 8.3, 8.1, and 7.5.
Highlights
- Restriction: Added a new restriction to the
IMPORT INTOdocumentation specifying that the target table must be entirely empty for import operations, including all partitions.
Changelog
- sql-statements/sql-statement-import-into.md
- Added a restriction that IMPORT INTO does not support importing data into an empty partition if other partitions of the same table already contain data. The target table must be completely empty for import operations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request adds a restriction to the IMPORT INTO documentation, specifying that the target table must be entirely empty for import operations, including all partitions. The change is well-described and applies to multiple TiDB versions. The addition is clear and concise, enhancing the documentation's accuracy.
Merge Readiness
The pull request is ready for merging. The change is straightforward and improves the documentation's clarity. There are no identified issues that would prevent merging. Since I am unable to approve the pull request, ensure that another reviewer approves this code before merging.
| @@ -21,6 +21,7 @@ The `IMPORT INTO` statement lets you import data to TiDB via the [Physical Impor | |||
| ## Restrictions | |||
|
|
|||
| - `IMPORT INTO` only supports importing data into existing empty tables in the database. | |||
| - `IMPORT INTO` does not support importing data into an empty partition if other partitions of the same table already contain data. The target table must be completely empty for import operations. | |||
There was a problem hiding this comment.
According to the style guide 1, avoid passive voice. Consider rephrasing to use active voice for better readability.
For example, you could change "The target table must be completely empty for import operations." to "Ensure the target table is completely empty for import operations."
Style Guide References
| - `IMPORT INTO` does not support importing data into an empty partition if other partitions of the same table already contain data. The target table must be completely empty for import operations. | |
| The target table must be completely empty for import operations. |
Footnotes
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #20562
What is changed, added or deleted? (Required)
Added a new restriction to the
IMPORT INTOdocumentation specifying that the target table must be entirely empty for import operations, including all partitions.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?