Skip to content

tiup: extend the firewall docs #20081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 20, 2025
Merged

tiup: extend the firewall docs #20081

merged 9 commits into from
Mar 20, 2025

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 21, 2025 •
edited
Loading

What is changed, added or deleted? (Required)

Besides disabling firewalld we can also change the zone to trusted and/or configure the services and add them to the zone.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from bb7133, Oreoxmt and qiancai January 21, 2025 10:52
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2025
@dveeden dveeden changed the title Tiup firewall tiup: extend the firewall docs Jan 21, 2025
@dveeden dveeden added the area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. label Jan 21, 2025
@dveeden dveeden requested a review from breezewish January 21, 2025 10:56
@dveeden dveeden mentioned this pull request Jan 22, 2025
Open
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Feb 26, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 26, 2025
@Oreoxmt Oreoxmt self-assigned this Mar 18, 2025
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 18, 2025

@dveeden dveeden#9 PTAL

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 18, 2025

@dveeden Please help confirm which TiDB versions this PR applies to

@dveeden
Copy link
Contributor Author

dveeden commented Mar 19, 2025

@dveeden Please help confirm which TiDB versions this PR applies to

This doesn't depend on a specific TiDB or TiUP version.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 19, 2025

@dveeden Please help confirm which TiDB versions this PR applies to

This doesn't depend on a specific TiDB or TiUP version.

I suggest we cherry-pick this PR to v8.1 and v8.5, which are the latest two LTS versions. The documentation for these versions are more frequently viewed by users..

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 19, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-26 08:22:02.084988551 +0000 UTC m=+430470.038146817: ☑️ agreed by breezewish.
  • 2025-03-19 08:56:44.085917279 +0000 UTC m=+432297.770153376: ☑️ agreed by Oreoxmt.

@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Mar 19, 2025
@Oreoxmt Oreoxmt added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. type/enhancement The issue or PR belongs to an enhancement. labels Mar 19, 2025
Oreoxmt
Oreoxmt reviewed Mar 19, 2025
View reviewed changes
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Mar 19, 2025
@Oreoxmt Oreoxmt mentioned this pull request Mar 19, 2025
Merged
15 tasks
@dveeden @Oreoxmt
Update check-before-deployment.md
2f180e4 
Co-authored-by: Aolin <aolinz@outlook.com>
hfxsd
hfxsd reviewed Mar 19, 2025
View reviewed changes
hfxsd
hfxsd reviewed Mar 19, 2025
View reviewed changes
hfxsd
hfxsd reviewed Mar 19, 2025
View reviewed changes
dveeden and others added 2 commits March 19, 2025 15:30
@dveeden @hfxsd
Update check-before-deployment.md
650aba6 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@dveeden @hfxsd
Update quick-start-with-tidb.md
e292a75 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 20, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 20, 2025
@ti-chi-bot ti-chi-bot bot merged commit 503336c into pingcap:master Mar 20, 2025
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 20, 2025
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20595.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 20, 2025
@dveeden @ti-chi-bot
This is an automated cherry-pick of pingcap#20081
71f722c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Mar 20, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20596.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 20, 2025
@dveeden @ti-chi-bot
tiup: extend the firewall docs (pingcap#20081)
c684c84
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 20, 2025
Merged
15 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Mar 20, 2025
@ti-chi-bot
tiup: extend the firewall docs (#20081) (#20596)
8497578
ti-chi-bot bot pushed a commit that referenced this pull request Mar 20, 2025
@ti-chi-bot
tiup: extend the firewall docs (#20081) (#20595)
f2ce02d
Oreoxmt pushed a commit that referenced this pull request Mar 26, 2025
@ti-chi-bot @Oreoxmt
tiup: extend the firewall docs (#20081) (#20595)
a744f5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@breezewish breezewish breezewish approved these changes

@hfxsd hfxsd hfxsd approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@qiancai qiancai Awaiting requested review from qiancai

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dveeden @Oreoxmt @ti-chi-bot @breezewish @hfxsd