Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: update ticdc-debezium.md #19544

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
de39cfc
wip
wk989898 Dec 2, 2024
8c957e5
Update ticdc-debezium.md
wk989898 Dec 6, 2024
a0dc693
Update ticdc-debezium.md
wk989898 Dec 6, 2024
793e485
Update ticdc-debezium.md
wk989898 Dec 6, 2024
66f2dde
Update ticdc-debezium.md
wk989898 Dec 6, 2024
b9c4f4b
Update ticdc-debezium.md
wk989898 Dec 6, 2024
6da4609
Update ticdc-debezium.md
wk989898 Dec 6, 2024
afc151e
Update ticdc-debezium.md
wk989898 Dec 9, 2024
19aa23c
Update ticdc-debezium.md
wk989898 Dec 9, 2024
61b0b2a
Update ticdc-debezium.md
wk989898 Dec 9, 2024
996d8f9
Update ticdc-debezium.md
wk989898 Dec 12, 2024
852aa42
ticdc: replace each hard Tab with four spaces
lilin90 Jan 6, 2025
abbe96d
ticdc: update format
lilin90 Jan 6, 2025
bc9013d
ticdc: avoid manual line breaks
lilin90 Jan 6, 2025
e6311da
ticdc: fix unclosed tags
lilin90 Jan 6, 2025
5c2a154
Update ticdc-debezium.md
wk989898 Jan 10, 2025
b4fbf1d
Update ticdc-debezium.md
wk989898 Jan 13, 2025
70688e0
Apply suggestions from code review
wk989898 Jan 24, 2025
da11ba4
Update ticdc-debezium.md
wk989898 Jan 24, 2025
0553e52
Update wording for consistency
lilin90 Feb 5, 2025
a3aa368
Apply suggestions from code review
wk989898 Feb 6, 2025
1e15afb
Apply suggestions from code review
wk989898 Feb 6, 2025
beb5c8b
Update according to comments on Chinese PR
lilin90 Feb 6, 2025
d1b79b4
Update wording for consistency
lilin90 Feb 6, 2025
3d3e58d
ticdc: improve format
lilin90 Feb 6, 2025
ab61ba3
Apply suggestions from code review
lilin90 Feb 7, 2025
35990d9
Remove extra spaces
lilin90 Feb 7, 2025
de26af5
Apply suggestions from code review
lilin90 Feb 7, 2025
9df3fce
Remove an extra space
lilin90 Feb 7, 2025
8954f1a
Apply suggestions from code review
lilin90 Feb 8, 2025
fefe294
Update format
lilin90 Feb 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Lilian Lee <lilin@pingcap.com>
  • Loading branch information
wk989898 and lilin90 authored Feb 6, 2025
commit a3aa3688ccb16692cf110e2e7ea485a139e8effd
4 changes: 2 additions & 2 deletions ticdc/ticdc-debezium.md
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ The key fields of the preceding JSON data are explained as follows:
| payload.tableChanges.table.columns.scale | Number | The scale of the column. |
| payload.tableChanges.table.columns.position | Number | The position of the column. |
| payload.tableChanges.table.columns.optional | Boolean | Indicates whether the column is optional. When it is `true`, the column is optional. |
| schema.fields | JSON | The type information of each field in the payload, including the schema information of the column of table changes. |
| schema.fields | JSON | The type information of each field in the payload, including the schema information of columns in the changed table. |
| schema.name | String | The name of the schema, in the `"{cluster-name}.{schema-name}.{table-name}.SchemaChangeValue"` format. |
| schema.optional | Boolean | Indicates whether the field is optional. When it is `true`, the field is optional. |
| schema.type | String | The data type of the field. |
Expand Down Expand Up @@ -796,7 +796,7 @@ The data format mapping in the TiCDC Debezium message basically follows the [Deb

- TiCDC print the wrong `flen` with the FLOAT [tidb#57060](https://github.com/pingcap/tidb/issues/57060).

- Debezium converts charsetName to "utf8mb4" when column COLLATE is "utf8_unicode_ci" and CHARACTER is null, but TiCDC does not.
- Debezium converts `charsetName` to `"utf8mb4"` when the column collation is `"utf8_unicode_ci"` and the character set is null, but TiCDC does not.

- Debezium escapes ENUM elements, but TiCDC does not. For example, Debezium encodes ENUM elements ('c', 'd', 'g,''h') to ('c','d','g,\'\'h').
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the example @wk989898. It does not display well.
image

lilin90 marked this conversation as resolved.
Show resolved Hide resolved

Expand Down
Loading