Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string-functions: Use MySQL 8.0 url instead of 8.3 #18243

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jul 15, 2024

What is changed, added or deleted? (Required)

  • MySQL 8.0 is a LTS release
  • MySQL 8.3 is an older innovation release

This link was causing a HTTP 302 redirect to the 8.4 page.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

- MySQL 8.0 is a LTS release
- MySQL 8.3 is an older innovation release

This link was causing a HTTP 302 redirect to the 8.4 page.
@dveeden dveeden requested review from hfxsd and qiancai July 15, 2024 09:11
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 16, 2024
Copy link

ti-chi-bot bot commented Jul 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-16 09:09:17.208172948 +0000 UTC m=+344979.199114453: ☑️ agreed by qiancai.

@qiancai qiancai added needs-cherry-pick-release-7.6 needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. translation/no-need No need to translate this PR. labels Jul 16, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 16, 2024
@qiancai qiancai self-assigned this Jul 16, 2024
@qiancai qiancai removed the translation/no-need No need to translate this PR. label Jul 16, 2024
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Jul 16, 2024
@qiancai qiancai added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 16, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jul 16, 2024

/approve

@qiancai qiancai added the lgtm label Jul 16, 2024
Copy link

ti-chi-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 16, 2024
@qiancai qiancai removed the request for review from hfxsd July 16, 2024 09:13
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit b72761c into pingcap:master Jul 16, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18261.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18262.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #18263.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 16, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #18264.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants