Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add Grafana monitoring best practices #1772

Merged
merged 23 commits into from
Jan 19, 2020

Conversation

junlan-zhang
Copy link
Contributor

@junlan-zhang junlan-zhang commented Jan 15, 2020

What is changed, added or deleted?

  • Add best practices for monitoring TiDB using Grafana

What is the related PR or file link(s)?

pingcap/docs-cn#1952
pingcap/docs-cn#2177
pingcap/docs-cn#2190

Which version does your change affect?

dev, v2.1, v3.0, v3.1

@junlan-zhang junlan-zhang added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jan 15, 2020
@junlan-zhang
Copy link
Contributor Author

PTAL @kissmydb Thanks~

@lilin90 lilin90 added the area/best-practices TiDB best practices label Jan 16, 2020
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
dev/reference/best-practices/grafana-monitor.md Outdated Show resolved Hide resolved
@junlan-zhang
Copy link
Contributor Author

PTAL again @lilin90 Thanks~

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junlan-zhang junlan-zhang merged commit 24773be into pingcap:master Jan 19, 2020
junlan-zhang added a commit that referenced this pull request Jan 19, 2020
@junlan-zhang
Copy link
Contributor Author

PTAL @kissmydb I will update your comments in a newly created PR. Thanks~

@kissmydb
Copy link
Contributor

kissmydb commented Feb 3, 2020

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/best-practices TiDB best practices translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants