Skip to content

Add warning and update wording for extended statistics #17670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 28, 2024
Merged

Add warning and update wording for extended statistics #17670

merged 6 commits into from
Jun 28, 2024

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented May 29, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added translation/no-need No need to translate this PR. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels May 29, 2024
@lilin90 lilin90 requested review from winoros and qiancai May 29, 2024 07:51
@lilin90 lilin90 self-assigned this May 29, 2024
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 29, 2024
lilin90
lilin90 commented May 29, 2024
View reviewed changes
qiancai
qiancai reviewed May 29, 2024
View reviewed changes
@lilin90 @qiancai
Refine wording
249aef7 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2024

@winoros: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90 @qiancai
Apply suggestions from code review
4d2077a 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2024
lilin90
lilin90 commented Jun 27, 2024
View reviewed changes
extended-statistics.md
Comment on lines +10 to +11
- Basic statistics: statistics such as histograms and Count-Min Sketch, which primarily focus on individual columns. They are essential for the optimizer to estimate the query cost. See [Introduction to Statistics](/statistics.md) for details.
- Extended statistics: statistics that focus on data correlations between specified columns, which guide the optimizer to estimate the query cost more precisely when the queried columns are correlated.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I'll update the corresponding two lines for docs in Chinese in a coming PR.

qiancai
qiancai approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 27, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-27 07:17:26.002589496 +0000 UTC m=+876772.488078338: ☑️ agreed by qiancai.

@lilin90 lilin90 added the lgtm label Jun 28, 2024
@lilin90
Copy link
Member Author

lilin90 commented Jun 28, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit c21ec6c into pingcap:master Jun 28, 2024
7 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-8.2: error checking out release-8.2: exit status 1. output: error: pathspec 'release-8.2' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18063.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2024
Merged
17 tasks
@lilin90 lilin90 deleted the update-extended-statistics branch June 28, 2024 06:08
ti-chi-bot bot pushed a commit that referenced this pull request Jun 28, 2024
@ti-chi-bot
Add warning and update wording for extended statistics (#17670) (#18063)
6f2f6da
@lilin90 lilin90 mentioned this pull request Jun 28, 2024
Merged
17 tasks
This was referenced Jul 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@lilin90 lilin90

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilin90 @ti-chi-bot @winoros @qiancai