Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: document logical-import-batch-{size,rows} #16790

Merged
merged 9 commits into from
Mar 25, 2024

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Mar 20, 2024

What is changed, added or deleted? (Required)

Document the Lightning configuration tikv-importer.logical-import-batch-size and -rows.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: kennytm <kennytm@gmail.com>
@kennytm kennytm added area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. v8.0 needs-cherry-pick-release-8.0 labels Mar 20, 2024
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2024
@hfxsd hfxsd self-assigned this Mar 21, 2024
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. for-release This PR relates to a TiDB release but does not have a tracked feature. and removed missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-8.0 labels Mar 21, 2024
Copy link

ti-chi-bot bot commented Mar 21, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 21, 2024
tidb-lightning/tidb-lightning-configuration.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-configuration.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-configuration.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-configuration.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from D3Hunter March 21, 2024 03:23
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Mar 21, 2024
Copy link

ti-chi-bot bot commented Mar 21, 2024

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd requested a review from Oreoxmt March 21, 2024 06:46
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tidb-lightning/tidb-lightning-configuration.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-configuration.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 22, 2024
Copy link

ti-chi-bot bot commented Mar 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-22 09:34:22.477193206 +0000 UTC m=+1628489.499439593: ☑️ agreed by Oreoxmt.

Co-authored-by: Aolin <aolinz@outlook.com>
@hfxsd hfxsd added the lgtm label Mar 25, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 25, 2024

/approve

Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1b37dfd into pingcap:master Mar 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants