Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference/best-practices: add PD scheduling best practice #1655

Merged
merged 8 commits into from
Dec 9, 2019

Conversation

anotherrachel
Copy link
Contributor

@anotherrachel anotherrachel commented Nov 15, 2019

What is changed, added or deleted?

This PR

  • added the PD Scheduling Best Practices
  • added Glossaries

What is the related PR or file link(s)?

pingcap/docs-cn#1990
pingcap/docs-cn#2003

Which version does your change affect?

dev, v2.1, v3.0 and v3.1

@anotherrachel anotherrachel added DNM translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/best-practices TiDB best practices labels Nov 15, 2019
@anotherrachel anotherrachel changed the title reference: add PD scheduling best practice reference/best-practices: add PD scheduling best practice Nov 15, 2019
@anotherrachel anotherrachel marked this pull request as ready for review November 15, 2019 06:47
@anotherrachel
Copy link
Contributor Author

@dcalvin @disksing PTAL, thanks~

dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first batch of review

dev/glossary.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first batch of review

dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/glossary.md Outdated Show resolved Hide resolved
dev/glossary.md Outdated Show resolved Hide resolved
dev/glossary.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/reference/best-practices/pd-scheduling.md Outdated Show resolved Hide resolved
dev/glossary.md Outdated Show resolved Hide resolved
dev/glossary.md Outdated Show resolved Hide resolved
@yikeke
Copy link
Contributor

yikeke commented Dec 7, 2019

pingcap/docs-cn#2106 removed two extra spaces from reference/best-practices/pd-scheduling.md. PTAL and align the changes in this PR. Thx~ @anotherrachel

Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please apply to other versions.

@anotherrachel anotherrachel merged commit 3737088 into pingcap:master Dec 9, 2019
@anotherrachel anotherrachel deleted the pd-best-practice branch January 7, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/best-practices TiDB best practices translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants