Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop: Update dev-guide-gui-navicat.md #16131

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

shawn0915
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

fix typo

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2024
@rpaik rpaik added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Jan 12, 2024
@qiancai qiancai requested a review from Icemap January 12, 2024 05:35
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Jan 12, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 12, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 15, 2024
Copy link

ti-chi-bot bot commented Jan 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-15 07:18:20.874095966 +0000 UTC m=+167542.438393656: ☑️ agreed by dveeden.
  • 2024-01-15 09:26:48.933868597 +0000 UTC m=+175250.498166302: ☑️ agreed by Icemap.

@shawn0915
Copy link
Contributor Author

@Icemap could you help on this? "Runtime error"
图片

@Icemap
Copy link
Member

Icemap commented Jan 22, 2024

@Icemap could you help on this? "Runtime error" 图片

Emmmm.. I don't know it either. @qiancai PTAL.

@shawn0915
Copy link
Contributor Author

/retest

Copy link

ti-chi-bot bot commented Jan 24, 2024

@shawn0915: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor

dveeden commented Jan 24, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 24, 2024
@dveeden
Copy link
Contributor

dveeden commented Jan 24, 2024

/retest

@shawn0915
Copy link
Contributor Author

/test ?

Copy link

ti-chi-bot bot commented Jan 24, 2024

@shawn0915: The following commands are available to trigger optional jobs:

  • /debug verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor

dveeden commented Jan 24, 2024

/verify

@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed translation/doing This PR's assignee is translating this PR. labels Jan 24, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jan 24, 2024

@Icemap could you help on this? "Runtime error" 图片

Emmmm.. I don't know it either. @qiancai PTAL.

@Icemap Usually, we can commit new changes to trigger the Vale check automatically.

@qiancai
Copy link
Collaborator

qiancai commented Jan 24, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2024
@ti-chi-bot ti-chi-bot bot merged commit 85f4a7a into pingcap:master Jan 24, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16296.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16297.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #16298.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16299.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16300.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16301.

@shawn0915 shawn0915 deleted the patch-5 branch January 25, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Development

Successfully merging this pull request may close these issues.

6 participants