Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how-to/maintain: add comma at the end of sql #1443

Merged
merged 1 commit into from
Aug 10, 2019
Merged

how-to/maintain: add comma at the end of sql #1443

merged 1 commit into from
Aug 10, 2019

Conversation

zhouqiang-cl
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl commented Aug 10, 2019 •
edited by lilin90
Loading

What is changed, added or deleted?

What is the related PR or file link(s)?

Add a comma at the end of an SQL statement

Which version does your change affect?

dev, v3.0, v2.1

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zhouqiang-cl
Copy link
Contributor Author

@GregoryIan @lilin90 PTAL

yikeke
yikeke approved these changes Aug 10, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl zhouqiang-cl merged commit 7787b25 into pingcap:master Aug 10, 2019
@lilin90 lilin90 changed the title add comma at the end of sql how-to/maintain: add comma at the end of sql Aug 12, 2019
@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Aug 12, 2019
@junlan-zhang junlan-zhang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Aug 19, 2019
@junlan-zhang junlan-zhang mentioned this pull request Aug 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@IANTHEREAL IANTHEREAL Awaiting requested review from IANTHEREAL

Assignees

@junlan-zhang junlan-zhang

Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhouqiang-cl @CLAassistant @yikeke @lilin90 @junlan-zhang