Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how-to/maintain: fix the description of backup & restore document #1416

Merged
merged 17 commits into from
Aug 6, 2019

Conversation

IANTHEREAL
Copy link
Contributor

What is changed, added or deleted?

the backup & restore document has some wrong descriptions

Which version does your change affect?

v3.0

IANTHEREAL and others added 2 commits August 6, 2019 14:27
@@ -83,6 +83,43 @@ In this command,
- `-F 64`: means a table is partitioned into chunks and one chunk is 64MB.
- `--skip-tz-utc`: the purpose of adding this parameter is to ignore the inconsistency of time zone setting between MySQL and the data exporting machine and to disable automatic conversion.

If `mydumper` meeting error likes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If `mydumper` meeting error likes
If `mydumper` emits errors like

v3.0/how-to/maintain/backup-and-restore.md Outdated Show resolved Hide resolved
v3.0/how-to/maintain/backup-and-restore.md Outdated Show resolved Hide resolved
- step 1: before executing `mydumper` command, you need to query the GC values of TiDB cluster and adjust it to a suitable value using the MySQL client:

```sql
mysql> select VARIABLE_NAME, VARIABLE_VALUE from mysql.tidb;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps use

SELECT * FROM mysql.tidb WHERE VARIABLE_NAME = 'tikv_gc_life_time'

to shorten the output below.

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM anyway 🤷‍♂

v3.0/how-to/maintain/backup-and-restore.md Outdated Show resolved Hide resolved
@lilin90 lilin90 changed the title fix the description of backup & restore document how-to/maintain: fix the description of backup & restore document Aug 6, 2019
@IANTHEREAL
Copy link
Contributor Author

thanks @lilin90

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit b2d422b into master Aug 6, 2019
@IANTHEREAL IANTHEREAL deleted the ian/3.0-backup branch August 6, 2019 08:42
@junlan-zhang junlan-zhang added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants