Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: support access by azure sas token #13896

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jun 15, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

support access blob by SAS (shared access signatures).

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2023
@Oreoxmt Oreoxmt self-assigned this Jun 15, 2023
@Oreoxmt Oreoxmt added v7.2 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 15, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 15, 2023
@Oreoxmt Oreoxmt self-requested a review June 15, 2023 07:21
br/backup-and-restore-storages.md Outdated Show resolved Hide resolved
br/backup-and-restore-storages.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 15, 2023
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace percent-encoding with URI component encoding.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

@YuJuncen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Maybe replace percent-encoding with URI component encoding.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt requested a review from qiancai June 15, 2023 08:57
br/backup-and-restore-storages.md Outdated Show resolved Hide resolved
br/backup-and-restore-storages.md Outdated Show resolved Hide resolved
Co-authored-by: Grace Cai <qqzczy@126.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 16, 2023

/retest

@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 16, 2023

/test-verify

@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 16, 2023

/verify

Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-15 07:56:43.926507848 +0000 UTC m=+245200.341111927: ☑️ agreed by Oreoxmt.
  • 2023-06-16 04:16:00.623461449 +0000 UTC m=+318357.038065521: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 21, 2023

/approve
/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit 9678807 into pingcap:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants