Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev, v3.0: align the placement expression for tidb-in-kubernetes, and fix some errors #1380

Merged
merged 4 commits into from
Jul 26, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Jul 26, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What is changed, added or deleted?

Align the placement expression for tidb-in-kubernetes, and fix some errors

Which version does your change affect?

dev 3.0

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@lilin90 @dcalvin @tennix @weekface @DanielZhangQD PTAL

…ome errors

Signed-off-by: Aylei <rayingecho@gmail.com>
aylei added 3 commits July 26, 2019 17:57
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcalvin dcalvin merged commit 379c47d into pingcap:master Jul 26, 2019
@lilin90 lilin90 changed the title dev,3.0: Align the placement expression for tidb-in-kubernetes, and fix some errors dev, v3.0: align the placement expression for tidb-in-kubernetes, and fix some errors Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants