Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add TiDB in K8s deployment files and reorganize toc #1324

Merged
merged 3 commits into from
Jul 5, 2019
Merged

*: add TiDB in K8s deployment files and reorganize toc #1324

merged 3 commits into from
Jul 5, 2019

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Jul 5, 2019 •
edited
Loading

What is changed, added or deleted?

  • Add new TiDB in K8s deployment files to TOC.md
  • Reorganize and rename some original deployment files to keep the URL consistent with that in docs-cn

What is the related PR or file link(s)?

pingcap/docs-cn#1542

Which version does your change affect?

dev, v3.0, _index.md

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@lilin90 lilin90 requested a review from yikeke July 5, 2019 03:41
@lilin90 lilin90 added the type/refactor The issue belongs to a refactor work. label Jul 5, 2019
yikeke
yikeke approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 01fc1e4 into pingcap:master Jul 5, 2019
@lilin90 lilin90 deleted the update-k8s-toc branch July 5, 2019 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
type/refactor The issue belongs to a refactor work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilin90 @yikeke