Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: add cdc summary monitor #13198

Merged
merged 3 commits into from
Apr 17, 2023
Merged

ticdc: add cdc summary monitor #13198

merged 3 commits into from
Apr 17, 2023

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

add CDC summary monitor

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang
add cdc summary monitor
98c2cfa 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-7.0 labels Apr 10, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 10, 2023
@ran-huang ran-huang requested a review from qiancai April 11, 2023 01:55
qiancai
qiancai reviewed Apr 11, 2023
View reviewed changes
TOC.md Show resolved Hide resolved
ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
@ran-huang @qiancai
Apply suggestions from code review
bedac77 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ran-huang ran-huang requested a review from qiancai April 14, 2023 05:40
qiancai
qiancai approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

ticdc/ticdc-summary-monitor.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2023
@ran-huang
address comments
6790f96 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
Copy link
Contributor Author

/merge
/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 17, 2023
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6790f96

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 17, 2023
@ti-chi-bot ti-chi-bot merged commit bbb96d6 into pingcap:master Apr 17, 2023
@ran-huang ran-huang deleted the cdc-summary-monitor branch April 17, 2023 09:25
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13251.

ti-chi-bot added a commit that referenced this pull request Apr 17, 2023
@ti-chi-bot
ticdc: add cdc summary monitor (#13198) (#13251)
38cfb0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@qiancai qiancai qiancai approved these changes

Assignees
No one assigned
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ran-huang @ti-chi-bot @asddongmen @qiancai