Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] tomcat-jdbc version update #13061

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[Update] tomcat-jdbc version update #13061

merged 1 commit into from
Mar 31, 2023

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented Mar 29, 2023 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Icemap Icemap added translation/no-need No need to translate this PR. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.4 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Mar 29, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 29, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from qiancai March 29, 2023 12:55
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 29, 2023
@Oreoxmt Oreoxmt added needs-cherry-pick-release-7.0 ONCALL Relates to documentation oncall. labels Mar 29, 2023
@Oreoxmt Oreoxmt self-requested a review March 29, 2023 13:02
Oreoxmt
Oreoxmt approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2023
@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 30, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 31, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8c1e806

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2023
@ti-chi-bot ti-chi-bot merged commit af896ac into pingcap:master Mar 31, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13074.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13075.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #13076.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13077.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13078.

ti-chi-bot added a commit that referenced this pull request Mar 31, 2023
@ti-chi-bot
[Update] tomcat-jdbc version update (#13061) (#13076)
2e29f30
ti-chi-bot added a commit that referenced this pull request Mar 31, 2023
@ti-chi-bot
[Update] tomcat-jdbc version update (#13061) (#13074)
cc72809
ti-chi-bot added a commit that referenced this pull request Mar 31, 2023
@ti-chi-bot
[Update] tomcat-jdbc version update (#13061) (#13077)
d2215bb
ti-chi-bot added a commit that referenced this pull request Mar 31, 2023
@ti-chi-bot
[Update] tomcat-jdbc version update (#13061) (#13075)
3436158
ti-chi-bot added a commit that referenced this pull request Mar 31, 2023
@ti-chi-bot
[Update] tomcat-jdbc version update (#13061) (#13078)
2a25eca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai Awaiting requested review from qiancai

Assignees
No one assigned
Labels
area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Icemap @ti-chi-bot @Oreoxmt @hfxsd