Skip to content

Conversation

lulukelu
Copy link

@lulukelu lulukelu commented Feb 15, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lulukelu lulukelu requested review from qiancai and ljun0712 February 15, 2023 04:27
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2023
@lulukelu lulukelu added area/security Relates to TiDB security and privilege. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. missing-translation-status This PR does not have translation status info. labels Feb 15, 2023
@qiancai qiancai added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels Feb 15, 2023
@qiancai qiancai changed the title Security faq cloud: update security FAQs Feb 15, 2023
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 15, 2023
@benj4min9e
Copy link

@lulukelu Please add me to the review list.

@lulukelu lulukelu requested a review from tennix February 15, 2023 06:12
lulukelu and others added 2 commits February 16, 2023 10:03

- Business data (including consumer data and table data)
- Database files (including database backups and snapshots)
- Logs (including SQL logs and )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what?


- Encryption: TiDB Cloud supports encryption at rest and in transit. Data is encrypted when it is stored on disk, and is also encrypted when it is transmitted over the network.

- Access controls: TiDB Cloud allows customers to control who has access to their data by setting up access controls list. Customers can set up roles and assign privileges to specific users.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Access controls: TiDB Cloud allows customers to control who has access to their data by setting up access controls list. Customers can set up roles and assign privileges to specific users.
- Access controls: TiDB Cloud allows customers to control who has access to their data by setting up an IP access list. In addition, TiDB Cloud allows customers to set up roles and assign privileges to specific users only.


- Access controls: TiDB Cloud allows customers to control who has access to their data by setting up access controls list. Customers can set up roles and assign privileges to specific users.

- Network security: TiDB Cloud is designed to run in a virtual private cloud (VPC) to isolate customer traffic from other traffic on the internet. TiDB Cloud also supports secure network communication using SSL/TLS.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Network security: TiDB Cloud is designed to run in a virtual private cloud (VPC) to isolate customer traffic from other traffic on the internet. TiDB Cloud also supports secure network communication using SSL/TLS.
- Network security: TiDB Cloud operates in a virtual private cloud (VPC) that isolates customer traffic from other traffic on the internet, and TiDB Cloud supports secure network communication using SSL/TLS.


- Network security: TiDB Cloud is designed to run in a virtual private cloud (VPC) to isolate customer traffic from other traffic on the internet. TiDB Cloud also supports secure network communication using SSL/TLS.

- Backup and disaster recovery: TiDB Cloud provides a variety of backup and disaster recovery options to ensure that customer data is protected in case of an outage or disaster. Customers can set up automatic backups, incremental backups, and point-in-time recovery, as well as replicate their data to different regions for disaster recovery.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Backup and disaster recovery: TiDB Cloud provides a variety of backup and disaster recovery options to ensure that customer data is protected in case of an outage or disaster. Customers can set up automatic backups, incremental backups, and point-in-time recovery, as well as replicate their data to different regions for disaster recovery.
- Backup and disaster recovery: TiDB Cloud provides a variety of backup and disaster recovery options to ensure that customer data is protected in case of an outage or disaster. Customers can set up automatic backups, incremental backups, and point-in-time recovery (PITR), and replicate their data to different regions for disaster recovery.


- Backup and disaster recovery: TiDB Cloud provides a variety of backup and disaster recovery options to ensure that customer data is protected in case of an outage or disaster. Customers can set up automatic backups, incremental backups, and point-in-time recovery, as well as replicate their data to different regions for disaster recovery.

- Compliance: TiDB Cloud is designed to comply with various data privacy and security regulations, such as ISO27701,SOC2,GDPR and HIPAA. Customers can also set up their own compliance requirements and audit logs to monitor access to their data.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Compliance: TiDB Cloud is designed to comply with various data privacy and security regulations, such as ISO27701SOC2GDPR and HIPAA. Customers can also set up their own compliance requirements and audit logs to monitor access to their data.
- Compliance: TiDB Cloud complies with various data privacy and security regulations, such as ISO27701, SOC2 Type II, General Data Protection Regulation (GDPR), and Health Insurance Portability and Accountability Act of 1996 (HIPAA). Customers can also set up their own compliance requirements and audit logs to monitor access to their data.

lulukelu and others added 2 commits February 21, 2023 12:58
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai
Copy link
Collaborator

qiancai commented Feb 21, 2023

/verify


As a customer, you have complete control over your data:

- You can choose how to protect your data using TiDB Cloud, which offers encryption at rest and in transit to safeguard your data. Additionally, you have the option to manage your encryption key. If you prefer to bring your key, contact [TiDB Cloud Support](/tidb-cloud/tidb-cloud-support.md).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not say this before the launch of CMEK offcially.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree,updated


- TiDB Cloud runs in a virtual private cloud (VPC) that isolates customer traffic from other traffic on the internet, and TiDB Cloud supports secure network communication using SSL/TLS.

- TiDB Cloud provides various backup and disaster recovery options to ensure that customer data is protected in case of an outage or disaster. Customers can set up automatic backups, incremental backups, and point-in-time recovery (PITR), and replicate their data to different regions for disaster recovery.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing all data safety (not security) related stuff from this section. Mixing disaster recovery mechanisms with security practices is not good.


- You can manage access to your data, as well as the TiDB Cloud databases and tools, through users, roles, and credentials that you control.

## Is customer data securely stored in TiDB Cloud?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section has some overlap with "How is customer data encrypted in TiDB Cloud?" later in the doc. Better to merge?


Customer data includes data that customers or their consumers store in TiKV or TiFlash, which is located in the cloud providers' storage (such as S3 buckets or EBS of AWS).

Customer data does not include TiDB Cloud diagnosis data, metadata:
Copy link
Collaborator

@qiancai qiancai Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Customer data does not include TiDB Cloud diagnosis data, metadata:
Customer data does not include TiDB Cloud diagnosis data or metadata:


## Who has control over customer data?

Customer have complete control over your data:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Customer have complete control over your data:
Customers have complete control over their data:

Comment on lines +38 to +40
- You can choose how to protect your data using TiDB Cloud, which offers encryption at rest and in transit to safeguard your data.

- You can manage access to your data, as well as the TiDB Cloud databases and tools, through user management that you control.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- You can choose how to protect your data using TiDB Cloud, which offers encryption at rest and in transit to safeguard your data.
- You can manage access to your data, as well as the TiDB Cloud databases and tools, through user management that you control.
- Customers can choose how to protect their data using TiDB Cloud, which offers encryption at rest and in transit to safeguard the data.
- Customers can manage access to their data, as well as the TiDB Cloud databases and tools, through user management.


## Who owns customer data?

Customer have the ownership of your customer data, and therefore have the right to decide which data can be processed, stored, and hosted by TiDB Cloud. TiDB Cloud will not access or utilize your customer data without your explicit permission.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Customer have the ownership of your customer data, and therefore have the right to decide which data can be processed, stored, and hosted by TiDB Cloud. TiDB Cloud will not access or utilize your customer data without your explicit permission.
Customers own their data and therefore have the right to decide which data can be processed, stored, and hosted by TiDB Cloud. TiDB Cloud cannot access or utilize customer data without customers' explicit permission.

@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2023
@qiancai
Copy link
Collaborator

qiancai commented Mar 31, 2023

hold this PR as the content is still not ready

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jul 27, 2023
@qiancai qiancai added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 4, 2024
@qiancai qiancai added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Nov 21, 2024
@qiancai
Copy link
Collaborator

qiancai commented Feb 7, 2025

Close this PR since the content is still not ready.

@qiancai qiancai closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Relates to TiDB security and privilege. area/tidb-cloud This PR relates to the area of TiDB Cloud. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants