Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add plan replayer capture #12281

Merged
merged 6 commits into from
Feb 13, 2023
Merged

sql: add plan replayer capture #12281

merged 6 commits into from
Feb 13, 2023

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jan 29, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

add plan replayer capture.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang
add plan replayer capture
65b580d 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
update sys var
eaf9b91 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. v6.6 labels Jan 29, 2023
@ran-huang ran-huang requested a review from TomShawn January 29, 2023 11:07
@ran-huang ran-huang self-assigned this Jan 29, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 29, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 29, 2023
TomShawn
TomShawn approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

sql-plan-replayer.md Outdated Show resolved Hide resolved
sql-plan-replayer.md Outdated Show resolved Hide resolved
sql-plan-replayer.md Outdated Show resolved Hide resolved
sql-plan-replayer.md Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 6, 2023
ran-huang and others added 3 commits February 6, 2023 17:11
@ran-huang @TomShawn
Apply suggestions from code review
aa6f0ca 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
add sql-plan-replayer.md to toc-tidb-cloud
3089df3 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
add custom content for sys var
fa9094a
@ran-huang
Copy link
Contributor Author

/verify

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2023
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ac9347

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2023
@ti-chi-bot ti-chi-bot merged commit dcdeda6 into pingcap:master Feb 13, 2023
@ran-huang ran-huang deleted the tidb_enable_plan_replayer branch February 13, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@Yisaer Yisaer Yisaer approved these changes

@songrijie songrijie Awaiting requested review from songrijie

Assignees

@ran-huang ran-huang

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ran-huang @ti-chi-bot @Yisaer @TomShawn