Skip to content

lightning: update the feature desc of pausing scheduling on table level #12153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2023
Merged

lightning: update the feature desc of pausing scheduling on table level #12153

merged 2 commits into from
Mar 7, 2023

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jan 18, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

The original description is inappropriate because physical import mode can be used in production environment even before v6.2.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang
update a feature desc
279a90e 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. require-LGT1 Indicates that the PR requires an LGTM. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. needs-cherry-pick-release-6.2 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Jan 18, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from Oreoxmt January 18, 2023 09:01
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2023
@ran-huang ran-huang removed the request for review from Oreoxmt January 18, 2023 09:02
@qiancai
Copy link
Collaborator

qiancai commented Feb 24, 2023 •
edited
Loading

Removed the needs-cherry-pick-release-6.3 label because the v6.3 docs have been archived at https://docs-archive.pingcap.com/tidb/v6.3 and will no longer receive new updates.

shichun-0415
shichun-0415 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2023
@ran-huang @shichun-0415
Update tidb-lightning/tidb-lightning-physical-import-mode-usage.md
195607f 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 195607f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2023
@ti-chi-bot ti-chi-bot merged commit 81b2659 into pingcap:master Mar 7, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 7, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #12801.

@ran-huang ran-huang deleted the lightning/fix-heading branch March 7, 2023 09:39
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 7, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12802.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 7, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #12803.

ti-chi-bot added a commit that referenced this pull request Mar 7, 2023
@ti-chi-bot
lightning: update the feature desc of pausing scheduling on table lev…
c66527a 
…el (#12153) (#12801)
ti-chi-bot added a commit that referenced this pull request Mar 7, 2023
@ti-chi-bot
lightning: update the feature desc of pausing scheduling on table lev…
ac4d65a 
…el (#12153) (#12802)
ran-huang added a commit that referenced this pull request Mar 7, 2023
@ti-chi-bot @ran-huang @shichun-0415
lightning: update the feature desc of pausing scheduling on table lev…
5108230 
…el (#12153) (#12803)

* update a feature desc

Signed-off-by: Ran <huangran.alex@gmail.com>

* Update tidb-lightning/tidb-lightning-physical-import-mode-usage.md

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

---------

Signed-off-by: Ran <huangran.alex@gmail.com>
Co-authored-by: Ran <huangran.alex@gmail.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ran-huang @ti-chi-bot @qiancai @shichun-0415