Skip to content

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Nov 18, 2022

Signed-off-by: Ping Yu yuping@pingcap.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Fix link of RawKV CDC. See rendered.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Ping Yu <yuping@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2022
@pingyu
Copy link
Contributor Author

pingyu commented Nov 18, 2022

@Oreoxmt @shichun-0415 PTAL, thanks~

@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for shichun-0415 November 18, 2022 02:27
@Oreoxmt Oreoxmt added type/bugfix This PR fixes a bug. needs-cherry-pick-release-6.2 translation/doing This PR's assignee is translating this PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. and removed missing-translation-status This PR does not have translation status info. labels Nov 18, 2022
@Oreoxmt Oreoxmt requested a review from shichun-0415 November 18, 2022 02:29
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2022
@Oreoxmt Oreoxmt added translation/no-need No need to translate this PR. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2022
@Oreoxmt Oreoxmt removed translation/doing This PR's assignee is translating this PR. status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2022
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 18, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 321765c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2022
@ti-chi-bot ti-chi-bot merged commit 5dd073a into pingcap:master Nov 18, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11354.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 18, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11355.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 18, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11356.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants