Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: Fix some words for TiKV API v2 #11271

Merged
merged 4 commits into from
Nov 14, 2022
Merged

tikv: Fix some words for TiKV API v2 #11271

merged 4 commits into from
Nov 14, 2022

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Nov 10, 2022 •
edited
Loading

Signed-off-by: pingyu yuping@pingcap.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

See rendered.

Please also note that some links to tikv.org is under developing, and will be finished in several days.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@pingyu
fix some words for TiKV API V2
25f02f1 
Signed-off-by: pingyu <yuping@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2022
@pingyu
Copy link
Contributor Author

pingyu commented Nov 10, 2022 •
edited
Loading

@Oreoxmt @haojinming @zeminzhou PTAL, thanks~

@Oreoxmt Oreoxmt self-requested a review November 11, 2022 02:37
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. from-doc-test v6.4 This PR/issue applies to TiDB v6.4. type/enhancement The issue or PR belongs to an enhancement. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. and removed missing-translation-status This PR does not have translation status info. labels Nov 11, 2022
haojinming
haojinming approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@haojinming haojinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zeminzhou
zeminzhou approved these changes Nov 11, 2022
View reviewed changes
Copy link

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM～

Oreoxmt
Oreoxmt approved these changes Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2022
shichun-0415
shichun-0415 reviewed Nov 14, 2022
View reviewed changes
tikv-configuration-file.md Outdated
+ Value options:
+ `1`: Uses API V1, does not encode the data passed from the client, and stores data as it is. In versions earlier than v6.1.0, TiKV uses API V1 by default.
+ `2`: Uses API V2:
+ The data is stored in the MVCC (Multi-Version Concurrency Control) format, where the timestamp is obtained from PD (which is TSO) by tikv-server.
+ Data is scoped according to different usage and supports co-existence of TiDB, Transactional KV, and RawKV applications in a single cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data supports co-existence of TiDB, Transactional KV, and RawKV applications in a single cluster is difficult to understand.

Oreoxmt
Oreoxmt reviewed Nov 14, 2022
View reviewed changes
@Oreoxmt @shichun-0415
Apply suggestions from code review
ea7a637 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 14, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 14, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0230971

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 14, 2022
@ti-chi-bot ti-chi-bot merged commit f8d776d into pingcap:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@haojinming haojinming haojinming approved these changes

@zeminzhou zeminzhou zeminzhou approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees
No one assigned
Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. from-doc-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pingyu @ti-chi-bot @Oreoxmt @haojinming @zeminzhou @shichun-0415