Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/lightning: update Lightning docs for v2.1.9 #1087

Merged
merged 7 commits into from
May 8, 2019
Merged

tools/lightning: update Lightning docs for v2.1.9 #1087

merged 7 commits into from
May 8, 2019

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Apr 27, 2019 •
edited
Loading

Update Lightning documentations for the new release (v2.1.9).

@kennytm kennytm marked this pull request as ready for review May 6, 2019 13:22
@kennytm kennytm requested a review from CaitinChen May 6, 2019 13:22
@kennytm
Copy link
Contributor Author

kennytm commented May 6, 2019

PTAL @CaitinChen @lonng

@kennytm kennytm changed the title [DNM] Update Lightning docs for v2.1.9 Update Lightning docs for v2.1.9 May 6, 2019
@lilin90 lilin90 changed the title Update Lightning docs for v2.1.9 tools/lightning: update Lightning docs for v2.1.9 May 7, 2019
@morgo morgo self-requested a review May 8, 2019 01:36
morgo
morgo approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lonng
lonng reviewed May 8, 2019
View reviewed changes
tools/lightning/deployment.md Outdated Show resolved Hide resolved
lonng
lonng reviewed May 8, 2019
View reviewed changes
tools/lightning/errors.md Outdated Show resolved Hide resolved
lonng
lonng reviewed May 8, 2019
View reviewed changes
tools/lightning/errors.md Outdated Show resolved Hide resolved
lonng
lonng reviewed May 8, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

lonng
lonng approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm merged commit d654dc4 into master May 8, 2019
@kennytm kennytm deleted the kennytm/lightning-docs-2019-05 branch May 8, 2019 07:37
@CaitinChen
Copy link
Contributor

CaitinChen commented May 9, 2019 •
edited
Loading

@dcalvin will update some wording and format in another PR.

@dcalvin dcalvin mentioned this pull request May 9, 2019
Merged
@huangxiuyan huangxiuyan mentioned this pull request May 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@lonng lonng lonng approved these changes

@CaitinChen CaitinChen Awaiting requested review from CaitinChen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennytm @CaitinChen @morgo @lonng