Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd-configuration-file: Docs for max-request-bytes is missing. #8817

Open
dveeden opened this issue Jun 7, 2022 · 4 comments
Open

pd-configuration-file: Docs for max-request-bytes is missing. #8817

dveeden opened this issue Jun 7, 2022 · 4 comments
Assignees
@Oreoxmt
Labels
add-missing-docs Add missing system variables to documentation area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. tracked This issue has been tracked.

Comments

@dveeden
Copy link
Contributor

dveeden commented Jun 7, 2022

Error Report

  1. What is the URL/path of the document related to this issue?
  1. How would you like to improve it?

Add documentation for this configuration item.
@dveeden
Copy link
Contributor Author

dveeden commented Jun 7, 2022

cc @rleungx @nolouch

@shichun-0415 shichun-0415 added the area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. label Jun 8, 2022
@rleungx
Copy link
Member

rleungx commented Jun 8, 2022

IMO, it's unnecessary to expose this config to the user. We don't expect the user to modify it because it could affect the online recovery when we use it to recover our cluster.

@dveeden
Copy link
Contributor Author

dveeden commented Jun 8, 2022

Shouldn't we then document that the configuration item exists and that we strongly advise users not to change it?

@rleungx
Copy link
Member

rleungx commented Jun 10, 2022

We also have other configs which are not exposed now. I'm not sure whether we should expose them with strong advice or not.

@Oreoxmt Oreoxmt added the add-missing-docs Add missing system variables to documentation label Aug 1, 2022
@shichun-0415 shichun-0415 added the tracked This issue has been tracked. label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Oreoxmt Oreoxmt

Labels
add-missing-docs Add missing system variables to documentation area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. tracked This issue has been tracked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dveeden @rleungx @Oreoxmt @shichun-0415