Skip to content

tikv: change cdc.min-ts-interval from 1s to 200ms #9871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

tikv: change cdc.min-ts-interval from 1s to 200ms #9871

merged 1 commit into from
Dec 5, 2022

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jun 16, 2022 •
edited by Oreoxmt
Loading

Signed-off-by: qupeng qupeng@pingcap.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hicqu
tikv: change cdc.min-ts-interval from 1s to 200ms
72f2d6f 
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 16, 2022 07:09
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2022
@TomShawn TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. translation/doing This PR’s assignee is translating this PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. v6.2 This PR/issue applies to TiDB v6.2. and removed missing-translation-status This PR does not have translation status info. for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Jun 16, 2022
@shichun-0415 shichun-0415 requested a review from Oreoxmt June 20, 2022 05:30
@shichun-0415 shichun-0415 added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 20, 2022
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 14, 2022
@Oreoxmt Oreoxmt mentioned this pull request Jul 14, 2022
Merged
13 tasks
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 20, 2022

@hicqu Could you please invite a tech review? Thanks~

@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
Oreoxmt
Oreoxmt approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2022
@Oreoxmt Oreoxmt added for-future-release This PR only applies to master for now and might cherry-pick to a future release. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed v6.2 This PR/issue applies to TiDB v6.2. labels Jul 26, 2022
overvenus
overvenus approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it will be released in v6.5.0

@Oreoxmt Oreoxmt added for-release This PR relates to a TiDB release but does not have a tracked feature. v6.5 This PR/issue applies to TiDB v6.5. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 5, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 72f2d6f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2022
@ti-chi-bot ti-chi-bot merged commit 0c89252 into pingcap:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Oreoxmt Oreoxmt

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. for-release This PR relates to a TiDB release but does not have a tracked feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.5 This PR/issue applies to TiDB v6.5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hicqu @ti-chi-bot @Oreoxmt @overvenus @TomShawn @shichun-0415