-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor/improve clarity: refactored and added more details about duplicate detection of tidb-lightning #9858
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @nova-xu! |
@sunzhaoyang 您好,我已经根据您的feedback做了相应的修改,麻烦您帮我看看还有没有什么需要改进的地方。多谢! |
LGTM 不过我建议 TOC 先不加,等重构的 PR 合并之后我再做一些合并的处理 cc @ran-huang /cc @gozssky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nova-xu please fix the error of " jenkins-docs-cn/verify " @ran-huang we have to merge this article with current duplicate detection document |
@sunzhaoyang You mean merge with this doc? |
@sunzhaoyang I fixed the previous manual line break error, but Jenkins still failed for another reason. I read the detailed information, but I'm not sure if this means my doc didn't pass the markdownlint check. |
/rebase |
@nova-xu Hi, sorry for the delayed response. Could you please merge commits from the master branch so we can proceed with the review? |
/rebase |
5ce4954
to
766fda7
Compare
Signed-off-by: Ran <huangran.alex@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged the content in this doc into tidb-lightning-logical-import-mode-usage.md
and tidb-lightning-physical-import-mode-usage.md
.
First-time contributors' checklist
What is changed, added or deleted? (Required)
之前的冲突检测杂糅在backend导入模式的配置介绍中,并且比较简略,不是太清晰。我结合现有的内容,创建了一个新的页面解释冲突检测,加入了详细的例子以及更多关于冲突检测的细节。
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?