Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 2 broken links in dm docs #9131

Merged
merged 1 commit into from
Apr 24, 2022
Merged

fix 2 broken links in dm docs #9131

merged 1 commit into from
Apr 24, 2022

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

Fix two broken links found in #8928

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang
fix 2 broken links in dm docs
0a99a3b 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang added translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 labels Apr 24, 2022
@ran-huang ran-huang requested a review from shichun-0415 April 24, 2022 03:09
@ran-huang ran-huang self-assigned this Apr 24, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2022
shichun-0415
shichun-0415 reviewed Apr 24, 2022
View reviewed changes
dm/shard-merge-best-practices.md
@@ -117,7 +117,7 @@ CREATE TABLE `tbl_multi_pk` (

## 上游 RDS 封装分库分表的处理

上游数据源为 RDS 且使用了其分库分表功能的情况下，MySQL binlog 中的表名在 SQL client 连接时可能并不可见。例如在 UCloud 分布式数据库 [UDDB](https://www.ucloud.cn/site/product/uddb.html) 中，其 binlog 表名可能会多出 `_0001` 的后缀。这需要根据 binlog 中的表名规律，而不是 SQL client 所见的表名，来配置 [table routing 规则](/dm/dm-key-features.md#table-routing)。
上游数据源为 RDS 且使用了其分库分表功能的情况下，MySQL binlog 中的表名在 SQL client 连接时可能并不可见。例如在 UCloud 分布式数据库 [UDDB](https://docs.ucloud.cn/uddb/README) 中，其 binlog 表名可能会多出 `_0001` 的后缀。这需要根据 binlog 中的表名规律，而不是 SQL client 所见的表名，来配置 [table routing 规则](/dm/dm-key-features.md#table-routing)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个二级标题和内容在 docs 仓库没见着，请帮忙看看是不是漏译了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等会儿补上

shichun-0415
shichun-0415 approved these changes Apr 24, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2022
@shichun-0415 shichun-0415 added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 24, 2022
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0a99a3b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2022
@ti-chi-bot ti-chi-bot merged commit 87e0ddf into pingcap:master Apr 24, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 24, 2022
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#9131
85b1f41 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9133.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9134.

@ran-huang ran-huang deleted the fix-broken-links branch April 24, 2022 05:23
ti-chi-bot added a commit that referenced this pull request Apr 24, 2022
@ti-chi-bot
fix 2 broken links in dm docs (#9131) (#9134)
c71f753
ti-chi-bot added a commit that referenced this pull request Apr 24, 2022
@ti-chi-bot
fix 2 broken links in dm docs (#9131) (#9133)
318c2f1
@ran-huang ran-huang added translation/no-need No need to translate this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@ran-huang ran-huang

Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @ti-chi-bot @shichun-0415