Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: checkpoint mechanism and common QA #8749
base: master
Are you sure you want to change the base?
dm: checkpoint mechanism and common QA #8749
Changes from all commits
0900e23
51de817
2a8325e
500f480
e370e4d
f3cdff5
67fe3ef
bf78428
2857b44
8e1035a
6e6d5c3
1421c9c
89798ee
31856b5
256203d
f74d2cc
e60b7b5
9d602a7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里有个困惑的地方,标题是
内存 checkpoint
,但内容上大半是flushed checkpoint
。整篇文档里没有很好地解释清楚这两个 checkpoint 的区别与联系。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
开头的地方有讲两种 checkpoint 代表的含义,简单来说
实际上,这里就是在解释两种 checkpoint 之间的联系——内存 checkpoint 是从 flushed checkpoint 恢复而来的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XID event 在文档里从未出现过,似乎是个 MySQL 的术语。为了避免读者疑惑,建议添加到 DM glossary 并链接过去。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这一句能否再明确一下,flush 的是什么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
就是 刷新内存中的 checkpoint 信息到持久化存储
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flush 还是一个比较常用的词汇,应该不用特别解释了。