Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description of can't mix multiple backend #8333

Merged
merged 8 commits into from
Mar 7, 2022
Merged

Add description of can't mix multiple backend #8333

merged 8 commits into from
Mar 7, 2022

Conversation

sunzhaoyang
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn February 11, 2022 02:33
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2022
glorv
glorv reviewed Feb 11, 2022
View reviewed changes
tidb-lightning/tidb-lightning-backends.md Outdated
@@ -31,6 +31,10 @@ TiDB Lightning 的[后端](/tidb-lightning/tidb-lightning-glossary.md#backend)
| 支持 TiDB 集群版本 | >= v4.0.0 | 全部 | 全部 |
| 是否影响 TiDB 对外提供服务 | 是 | 是 | 否 |

> **注意：**
>
> 严禁使用多个 Lightning 进程向同一目标导入时混用不同的 backend，例如同时使用 local-backend 和 tidb-backend 导入同一 TiDB 集群是不允许的。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉这里应该说明一下，在默认情况下，不应该启动多个 TiDB Lightning 向同一个下游集群导入数据，如果需要的话，应该参考 并行导入 章节的内容。

tidb-lightning/tidb-lightning-distributed-import.md Outdated
> 并行导入只支持初始化 TiDB 的空表，不支持导入数据到已有业务写入的数据表，否则可能会导致数据不一致的情况。
> 1. 并行导入只支持初始化 TiDB 的空表，不支持导入数据到已有业务写入的数据表，否则可能会导致数据不一致的情况。
>
> 2. 并行导入一般用于 local-backend 模式，虽然在 tidb-backend 模式下也可以工作，但并无太大意义。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidb-backend 在某些情况下可能是有意义的，如果确认下游 tidb 不是瓶颈的话，我倾向于把 tidb backend 和 local backend 对于并行导入的支持区分开。不过考虑到 tidb backend 需要并行的场景应该有限，我们可以在一个小的章节里面简单提一下就好。tidb backend 的 并行依然需要满足部署限制里面的要求。

@shichun-0415 shichun-0415 added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. and removed missing-translation-status This PR does not have translation status info. labels Feb 11, 2022
shichun-0415
shichun-0415 reviewed Feb 20, 2022
View reviewed changes
tidb-lightning/tidb-lightning-backends.md Outdated
@@ -31,6 +31,10 @@ TiDB Lightning 的[后端](/tidb-lightning/tidb-lightning-glossary.md#backend)
| 支持 TiDB 集群版本 | >= v4.0.0 | 全部 | 全部 |
| 是否影响 TiDB 对外提供服务 | 是 | 是 | 否 |

> **注意：**
>
> 严禁使用多个 Lightning 进程向同一目标导入时混用不同的 backend，例如同时使用 local-backend 和 tidb-backend 导入同一 TiDB 集群是不允许的。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> 严禁使用多个 Lightning 进程向同一目标导入时混用不同的 backend，例如同时使用 local-backend 和 tidb-backend 导入同一 TiDB 集群是不允许的。
> 默认情况下，不使用多个 TiDB Lightning 向同一个下游集群导入数据，如果特殊情况需要，可参考[并行导入](/tidb-lightning/tidb-lightning-distributed-import.md)。
> 使用多个 TiDB Lightning 向同一目标导入时，禁止混用不同的 backend，例如，不可同时使用 Local-backend 和 TiDB-backend 导入同一 TiDB 集群。

tidb-lightning/tidb-lightning-distributed-import.md Outdated
>
> 2. 并行导入一般用于 local-backend 模式，虽然在 tidb-backend 模式下也可以工作，但并无太大意义。
>
> 3. 严禁使用多个 Lightning 进程向同一目标导入时混用不同的 backend，例如同时使用 local-backend 和 tidb-backend 导入同一 TiDB 集群是不允许的。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> 3. 严禁使用多个 Lightning 进程向同一目标导入时混用不同的 backend，例如同时使用 local-backend 和 tidb-backend 导入同一 TiDB 集群是不允许的。
> 3. 使用多个 TiDB Lightning 向同一目标导入时，禁止混用不同的 backend，例如，不可同时使用 Local-backend 和 TiDB-backend 导入同一 TiDB 集群。

sunzhaoyang and others added 3 commits February 28, 2022 19:07
@sunzhaoyang
fix commetns
e60f0af
@sunzhaoyang
fix-comments
40e261c
@sunzhaoyang @shichun-0415
Apply suggestions from code review
0b14eda 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@TomShawn TomShawn added area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. and removed area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. labels Mar 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2022
@shichun-0415 shichun-0415 added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 7, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8b66304

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2022
@ti-chi-bot ti-chi-bot merged commit 6247770 into pingcap:master Mar 7, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 7, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8585.

ti-chi-bot added a commit that referenced this pull request Mar 7, 2022
@ti-chi-bot
Add description of can't mix multiple backend (#8333) (#8585)
47d9ddd
@shichun-0415 shichun-0415 mentioned this pull request Mar 7, 2022
Merged
16 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 7, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 10, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@hfxsd hfxsd

@shichun-0415 shichun-0415

Labels
area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sunzhaoyang @ti-chi-bot @shichun-0415 @glorv @hfxsd @TomShawn