Skip to content

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Nov 8, 2021

What is changed, added or deleted? (Required)

Revised the order of system variables into alphabetical order.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch: might cause conflicts to 5.0, 5.1, 5.2 versions.

@en-jin19 en-jin19 requested a review from TomShawn November 8, 2021 08:32
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021
@en-jin19
Copy link
Contributor Author

en-jin19 commented Nov 8, 2021

/label version-specific-changes-required

@ti-chi-bot
Copy link
Member

@en-jin19: The label(s) version-specific-changes-required cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v5.1, v5.2, v5.3, for-future-release, requires-version-specific-changes, website.

In response to this:

/label version-specific-changes-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@en-jin19 en-jin19 added needs-cherry-pick-release-5.0 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. and removed missing-translation-status This PR does not have translation status info. labels Nov 8, 2021
@TomShawn TomShawn added the area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. label Nov 8, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn November 8, 2021 08:49
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 9, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Nov 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebbef48

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2021
@ti-chi-bot ti-chi-bot merged commit d545f7c into pingcap:master Nov 9, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 9, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7440.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 9, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7441.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 9, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7442.

@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants