Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb: fix default value of performance.committer-concurrency #7116

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

amyangfei
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

The default value of performance.committer-concurrency has changed from 16 to 128 since v5.1.0

ref: https://docs.pingcap.com/zh/tidb/dev/release-5.1.0#%E9%85%8D%E7%BD%AE%E6%96%87%E4%BB%B6%E5%8F%82%E6%95%B0 performance.committer-concurrency

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn September 12, 2021 06:33
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2021
@TomShawn TomShawn self-assigned this Sep 14, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.1 sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. and removed missing-translation-status This PR does not have translation status info. labels Sep 14, 2021
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. require-LGT1 Indicates that the PR requires an LGTM. labels Sep 14, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5469353

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 14, 2021
@TomShawn TomShawn closed this Sep 14, 2021
@TomShawn TomShawn reopened this Sep 14, 2021
@ti-chi-bot ti-chi-bot merged commit 6bb1a4e into pingcap:master Sep 14, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7120.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7121.

@TomShawn TomShawn removed the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Sep 14, 2021
@TomShawn TomShawn assigned shichun-0415 and unassigned TomShawn Sep 15, 2021
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants