Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify tidb lightning backend description #6468

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Clarify tidb lightning backend description #6468

merged 2 commits into from
Jun 18, 2021

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Clarify tidb lightning backend description

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2021
@TomShawn TomShawn added needs-cherry-pick-release-4.0 sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-release-4.0 labels Jun 18, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2021
@TomShawn TomShawn requested review from glorv, kennytm and Joyinqin June 18, 2021 05:29
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45ebee9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-chi-bot ti-chi-bot merged commit 945e4e7 into release-4.0 Jun 18, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6469.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 18, 2021
Merged
11 tasks
@TomShawn TomShawn deleted the TomShawn-patch-2 branch June 18, 2021 05:49
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 18, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6470.

ti-chi-bot added a commit that referenced this pull request Jun 18, 2021
@ti-chi-bot
Clarify tidb lightning backend description (#6468) (#6470)
9c4f6d4
ti-chi-bot added a commit that referenced this pull request Jun 18, 2021
@ti-chi-bot
Clarify tidb lightning backend description (#6468) (#6469)
01a2a24
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 1, 2021
Merged
11 tasks
@Liuxiaozhen12
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 1, 2021
This was referenced Jul 1, 2021
Merged
Merged
Merged
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@ti-chi-bot @3AceShowHand
Clarify tidb lightning backend description (pingcap#6468) (pingcap#6469)
9e23bf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joyinqin Joyinqin Joyinqin approved these changes

@kennytm kennytm kennytm approved these changes

@glorv glorv Awaiting requested review from glorv

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. needs-cherry-pick-master Should cherry pick this PR to master branch. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @ti-chi-bot @Liuxiaozhen12 @kennytm @Joyinqin