Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dumpling-overview.md #6060

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Update dumpling-overview.md #6060

merged 3 commits into from
Apr 20, 2021

Conversation

pepezzzz
Copy link
Contributor

add full backup ftwrl details

First-time contributors' checklist

What is changed, added or deleted? (Required)

add full backup ftwrl details

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • [] v3.1 (TiDB 3.1 versions)
  • [] v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@pepezzzz
Update dumpling-overview.md
8f8a877 
add full backup ftwrl details
@ti-chi-bot ti-chi-bot requested a review from TomShawn April 19, 2021 09:24
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2021
@TomShawn
Copy link
Contributor

/cc @lichunzhu

@ti-chi-bot ti-chi-bot requested a review from lichunzhu April 19, 2021 09:24
lichunzhu
lichunzhu reviewed Apr 19, 2021
View reviewed changes
dumpling-overview.md Outdated
@@ -258,7 +258,7 @@ Dumpling 也可以通过 `-B` 或 `-T` 选项导出特定的数据库/数据表

Dumpling 通过 `--consistency <consistency level>` 标志控制导出数据“一致性保证”的方式。对于 TiDB 来说，默认情况下，会通过获取某个时间戳的快照来保证一致性（即 `--consistency snapshot`）。在使用 snapshot 来保证一致性的时候，可以使用 `--snapshot` 选项指定要备份的时间戳。还可以使用以下的一致性级别：

- `flush`：使用 [`FLUSH TABLES WITH READ LOCK`](https://dev.mysql.com/doc/refman/8.0/en/flush.html#flush-tables-with-read-lock) 来保证一致性。
- `flush`：使用 [`FLUSH TABLES WITH READ LOCK`](https://dev.mysql.com/doc/refman/8.0/en/flush.html#flush-tables-with-read-lock) 短暂地中断备份库的 DML 和 DDL 操作，保证并发备份连接的全局一致性和记录 pos 信息，所有的并发备份连接建立后释放该锁。推荐在业务低峰或者 MySQL 备库上进行全量备份。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有的并发备份连接建立后释放该锁。
该句不准确，释放锁的时机目前由 --transactional-consistency 控制。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有的并发备份连接建立后释放该锁->所有的并发备份连接启动事务后释放该锁 ?

@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-4.0
/label needs-cherry-pick-master
/translation doing
/cc @Joyinqin
/status LGT1

@ti-chi-bot ti-chi-bot requested a review from Joyinqin April 19, 2021 09:52
@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-4.0 needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 19, 2021
@TomShawn
Copy link
Contributor

/uncc @Joyinqin
/assign Joyinqin

@ti-chi-bot ti-chi-bot removed the request for review from Joyinqin April 19, 2021 09:53
TomShawn
TomShawn reviewed Apr 20, 2021
View reviewed changes
dumpling-overview.md Outdated Show resolved Hide resolved
@pepezzzz @TomShawn
Update dumpling-overview.md
6036654 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

/lgtm

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6036654

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2021
@ti-chi-bot ti-chi-bot merged commit 30c6f28 into pingcap:release-5.0 Apr 20, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 20, 2021
@pepezzzz @ti-srebot
cherry pick pingcap#6060 to release-4.0
ac4580e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #6084

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 20, 2021
@pepezzzz @ti-srebot
cherry pick pingcap#6060 to master
a56b2ec 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #6085

ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Update dumpling-overview.md (#6060) (#6084)
e324931
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Update dumpling-overview.md (#6060) (#6085)
327a607
@Joyinqin Joyinqin mentioned this pull request Apr 23, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 23, 2021
This was referenced Apr 23, 2021
Merged
Merged
@CharLotteiu CharLotteiu mentioned this pull request Apr 27, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@lichunzhu lichunzhu lichunzhu left review comments

Assignees

@Joyinqin Joyinqin

Labels
contribution This PR is from a community contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pepezzzz @TomShawn @lichunzhu @ti-chi-bot @ti-srebot @Joyinqin