Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "prepared plan cache: Enable by default" #5811

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Revert "prepared plan cache: Enable by default" #5811

merged 2 commits into from
Mar 26, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Mar 24, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

This reverts commit 6000b95.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2021
@Joyinqin Joyinqin changed the title Revert "prepared plan cache: Enable by default Revert "prepared plan cache: Enable by default" Mar 24, 2021
@Joyinqin
Copy link
Contributor Author

/translation from-docs

@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed missing-translation-status This PR does not have translation status info. labels Mar 24, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label v5.0

@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0 labels Mar 24, 2021
@Joyinqin
Copy link
Contributor Author

/cc @TomShawn @eurekaka

@ti-chi-bot ti-chi-bot requested review from eurekaka and TomShawn March 24, 2021 05:44
eurekaka
eurekaka approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

@eurekaka: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yikeke yikeke requested review from ran-huang and removed request for TomShawn March 25, 2021 07:04
@yikeke
Copy link
Contributor

yikeke commented Mar 25, 2021

Please help review the PR, thx. @ran-huang

ran-huang
ran-huang reviewed Mar 25, 2021
View reviewed changes
@ran-huang
Copy link
Contributor

@Joyinqin Please address comments. Thanks~

@Joyinqin @ran-huang
Apply suggestions from code review
5b45ce7 
Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang
Copy link
Contributor

/label require-LGT1
/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added require-LGT1 Indicates that the PR requires an LGTM. status/LGT1 Indicates that a PR has LGTM 1. labels Mar 26, 2021
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5b45ce7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2021
@ti-chi-bot ti-chi-bot merged commit 32c1a0b into pingcap:master Mar 26, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 26, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5811 to release-5.0
21def87 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5857

ti-chi-bot pushed a commit that referenced this pull request Mar 26, 2021
@ti-srebot
Revert "prepared plan cache: Enable by default" (#5811) (#5857)
54e29a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Joyinqin @ti-chi-bot @yikeke @ran-huang @ti-srebot @eurekaka