-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releases: add tidb v4.0.11 release notes #5458
Conversation
/label needs-cherry-pick-4.0, needs-cherry-pick-5.0 |
/label translation/from-docs |
releases/release-4.0.11.md
Outdated
|
||
+ TiFlash | ||
|
||
- 增加排队处理 Coprocessor 任务的线程池以减小内存溢出几率,并增加配置项 `cop_pool_size` 和 `batch_cop_pool_size`,默认值为 `物理核数 * 2` [#1312](https://github.com/pingcap/tics/pull/1312) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In “减小内存溢出几率”, could we update “减小” to “降低”?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Changed to “降低”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
releases/release-4.0.11.md
Outdated
- 修复生成多个 join 相关 hint 可能 panic 的问题 [#22518](https://github.com/pingcap/tidb/pull/22518) | ||
- 修复转换字符串为 `BIT` 类型不准确的问题 [#22420](https://github.com/pingcap/tidb/pull/22420) | ||
- 修复插入 `tidb_rowid` 列时出现的 `index out of range` 报错问题 [#22359](https://github.com/pingcap/tidb/pull/22359) | ||
- 修复缓存计划被错误的使用问题 [#22353](https://github.com/pingcap/tidb/pull/22353) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“修复缓存计划被错误的使用问题” looks confusing, does it mean “修复缓存计划被错误使用的问题” or “修复缓存计划被错误地使用的问题”?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The English version is "Fix a bug that the cached plan is incorrectly used". I think it should be “修复缓存计划被错误地使用的问题”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- 修正 Coprocessor 中错误解析 Decimal 常量的问题 | ||
- 修正 Learner Read 过程中可能导致 crash 的问题 | ||
- 修正 TiFlash 中除 `0` 或 `NULL` 的行为与 TiDB 不一致的问题 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 138 to line 143, the verb "修正“ is used, while in all other notes in this document, "修复“ is used. Suggest using "修复“ consistently in this document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
releases/release-4.0.11.md
Outdated
- 修正 DDL 操作后写入的数据可能会在 compaction 后丢失的问题 | ||
- 修正 Coprocessor 中错误解析 Decimal 常量的问题 | ||
- 修正 Learner Read 过程中可能导致 crash 的问题 | ||
- 修正 TiFlash 中除 `0` 或 `NULL` 的行为与 TiDB 不一致的问题 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In "修正 TiFlash 中除 0
或 NULL
的行为与 TiDB 不一致的问题", is "除 0
或 NULL
的行为" correct? Does it mean "除以0
或 `NULL". Would you please double check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As confirmed with @zanmato1984, it should be "除以 0
或 NULL
". However, "除 0
或 NULL
" is also commonly used among programmers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@qiancai All comments are addressed. PTAL again, thanks! |
LGTM |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #5623 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #5624 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
LGTM |
What is changed, added or deleted? (Required)
add tidb v4.0.11 release notes
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?