Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releases: add tidb v4.0.11 release notes #5458

Merged
merged 28 commits into from
Feb 26, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Feb 1, 2021

What is changed, added or deleted? (Required)

add tidb v4.0.11 release notes

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Feb 1, 2021

/label needs-cherry-pick-4.0, needs-cherry-pick-5.0

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Feb 1, 2021

/label translation/from-docs

@ti-srebot ti-srebot added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Feb 1, 2021
releases/release-4.0.11.md Show resolved Hide resolved
releases/release-4.0.11.md Show resolved Hide resolved
releases/release-4.0.11.md Show resolved Hide resolved
releases/release-4.0.11.md Show resolved Hide resolved
releases/release-4.0.11.md Show resolved Hide resolved

+ TiFlash

- 增加排队处理 Coprocessor 任务的线程池以减小内存溢出几率,并增加配置项 `cop_pool_size` 和 `batch_cop_pool_size`,默认值为 `物理核数 * 2` [#1312](https://github.com/pingcap/tics/pull/1312)
Copy link
Collaborator

@qiancai qiancai Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In “减小内存溢出几率”, could we update “减小” to “降低”?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Changed to “降低”.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- 修复生成多个 join 相关 hint 可能 panic 的问题 [#22518](https://github.com/pingcap/tidb/pull/22518)
- 修复转换字符串为 `BIT` 类型不准确的问题 [#22420](https://github.com/pingcap/tidb/pull/22420)
- 修复插入 `tidb_rowid` 列时出现的 `index out of range` 报错问题 [#22359](https://github.com/pingcap/tidb/pull/22359)
- 修复缓存计划被错误的使用问题 [#22353](https://github.com/pingcap/tidb/pull/22353)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“修复缓存计划被错误的使用问题” looks confusing, does it mean “修复缓存计划被错误使用的问题” or “修复缓存计划被错误地使用的问题”?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English version is "Fix a bug that the cached plan is incorrectly used". I think it should be “修复缓存计划被错误地使用的问题”.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- 修正 Coprocessor 中错误解析 Decimal 常量的问题
- 修正 Learner Read 过程中可能导致 crash 的问题
- 修正 TiFlash 中除 `0` 或 `NULL` 的行为与 TiDB 不一致的问题

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 138 to line 143, the verb "修正“ is used, while in all other notes in this document, "修复“ is used. Suggest using "修复“ consistently in this document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Collaborator

@qiancai qiancai Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

releases/release-4.0.11.md Outdated Show resolved Hide resolved
releases/release-4.0.11.md Outdated Show resolved Hide resolved
- 修正 DDL 操作后写入的数据可能会在 compaction 后丢失的问题
- 修正 Coprocessor 中错误解析 Decimal 常量的问题
- 修正 Learner Read 过程中可能导致 crash 的问题
- 修正 TiFlash 中除 `0` 或 `NULL` 的行为与 TiDB 不一致的问题
Copy link
Collaborator

@qiancai qiancai Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In "修正 TiFlash 中除 0NULL 的行为与 TiDB 不一致的问题", is "除 0NULL 的行为" correct? Does it mean "除以0 或 `NULL". Would you please double check?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As confirmed with @zanmato1984, it should be "除以 0NULL". However, "除 0NULL" is also commonly used among programmers.

Copy link
Collaborator

@qiancai qiancai Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

@qiancai All comments are addressed. PTAL again, thanks!

@qiancai
Copy link
Collaborator

qiancai commented Feb 26, 2021

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 26, 2021
@TomShawn TomShawn merged commit cb49aa2 into pingcap:master Feb 26, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Feb 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5623

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Feb 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5624

TomShawn pushed a commit that referenced this pull request Feb 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request Feb 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@scsldb
Copy link
Contributor

scsldb commented Feb 26, 2021

LGTM

@ti-srebot
Copy link
Contributor

@scsldb, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.