Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in 5.0 RC release notes #5310

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Fix a typo in 5.0 RC release notes #5310

merged 1 commit into from
Jan 14, 2021

Conversation

glkappe
Copy link
Contributor

@glkappe glkappe commented Jan 14, 2021 •
edited
Loading

tbl_name change to table_name

image
请进行技术评估

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@glkappe
修改 sql 列名
fb8597c 
tbl_name change to table_name

请进行技术评估
@TomShawn TomShawn requested a review from scsldb January 14, 2021 08:32
@TomShawn TomShawn assigned TomShawn and Joyinqin and unassigned TomShawn Jan 14, 2021
@TomShawn TomShawn added needs-cherry-pick-5.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Jan 14, 2021
@TomShawn TomShawn changed the title 修改 sql 列名 Fix a typo in 5.0 RC release notes Jan 14, 2021
@scsldb
Copy link
Contributor

scsldb commented Jan 14, 2021

LGTM

@ti-srebot
Copy link
Contributor

@scsldb, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 14, 2021
@TomShawn TomShawn merged commit d8ee3bf into pingcap:master Jan 14, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 14, 2021
@glkappe @ti-srebot
cherry pick pingcap#5310 to release-5.0
9e49f9e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 14, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5311

TomShawn pushed a commit that referenced this pull request Jan 14, 2021
@ti-srebot @glkappe
cherry pick #5310 to release-5.0 (#5311)
e0a717a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: glkappe <qihang.li@pingcap.com>
@TomShawn TomShawn assigned TomShawn and unassigned Joyinqin Jan 18, 2021
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 18, 2021
@TomShawn TomShawn mentioned this pull request Jan 18, 2021
Merged
10 tasks
@ti-srebot ti-srebot mentioned this pull request Jan 18, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@scsldb scsldb Awaiting requested review from scsldb

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glkappe @scsldb @ti-srebot @TomShawn @Joyinqin