Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bg_task_io_rate_limit setting experimental #5180

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Make bg_task_io_rate_limit setting experimental #5180

merged 3 commits into from
Dec 28, 2020

Conversation

flowbehappy
Copy link
Contributor

What is changed, added or deleted? (Required)

Make bg_task_io_rate_limit setting in tiflash.toml experimental. Since it is released as experimental feature in 5.0.0-rc.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@flowbehappy flowbehappy mentioned this pull request Dec 28, 2020
Merged
9 tasks
TomShawn
TomShawn approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2020
@TomShawn TomShawn added size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0 labels Dec 28, 2020
@TomShawn TomShawn merged commit 22ccc4c into pingcap:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees

@flowbehappy flowbehappy

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flowbehappy @TomShawn @ti-srebot