Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explain: add joins #4933

Merged
merged 6 commits into from
Feb 20, 2021
Merged

explain: add joins #4933

merged 6 commits into from
Feb 20, 2021

Conversation

CharLotteiu
Copy link
Contributor

What is changed, added or deleted? (Required)

Add explain-joins.md. This PR does not add this page to the TOC.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@CharLotteiu CharLotteiu added translation/from-docs This PR is translated from a PR in pingcap/docs. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Nov 20, 2020
@CharLotteiu CharLotteiu requested a review from TomShawn November 20, 2020 06:09
@TomShawn TomShawn requested a review from SunRunAway November 20, 2020 07:27
@ti-srebot
Copy link
Contributor

@SunRunAway, @TomShawn, PTAL.

@TomShawn TomShawn added the requires-followup This PR requires a follow-up task after being merged. label Nov 23, 2020
@ti-srebot
Copy link
Contributor

@SunRunAway, @TomShawn, PTAL.

TomShawn
TomShawn reviewed Nov 26, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments on the format.
Great translation!

explain-joins.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
@CharLotteiu @TomShawn
Apply suggestions from code review
ed4479f 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot
Copy link
Contributor

@TomShawn, @SunRunAway, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@TomShawn, @SunRunAway, PTAL.

@TomShawn
Copy link
Contributor

TomShawn commented Dec 1, 2020 •
edited
Loading

LGTM
@SunRunAway @lzmhhh123 PTAL, thanks~

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @SunRunAway, PTAL.

lzmhhh123
lzmhhh123 approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@lzmhhh123, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn merged commit eecc5ee into pingcap:master Feb 20, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Feb 20, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#4933 to release-4.0
9ed073d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 20, 2021
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5553

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Feb 20, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#4933 to release-5.0
9cfafd8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 20, 2021
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5554

TomShawn pushed a commit that referenced this pull request Feb 20, 2021
@ti-srebot @CharLotteiu
cherry pick #4933 to release-4.0 (#5553)
0877179 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request Feb 20, 2021
@ti-srebot @CharLotteiu
cherry pick #4933 to release-5.0 (#5554)
7968a2b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Feb 23, 2021
@TomShawn TomShawn mentioned this pull request Feb 23, 2021
Merged
10 tasks
This was referenced Nov 10, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharLotteiu @ti-srebot @TomShawn @lzmhhh123