Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb binlog: refine relay log description #4867

Merged
merged 3 commits into from
Nov 11, 2020
Merged

tidb binlog: refine relay log description #4867

merged 3 commits into from
Nov 11, 2020

Conversation

csuzhangxc
Copy link
Member

What is changed, added or deleted? (Required)

refine TiDB-Binlog relay log

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@csuzhangxc
Copy link
Member Author

@seiya-annie @july2993 PTAL

@csuzhangxc csuzhangxc mentioned this pull request Nov 10, 2020
Closed
@ti-srebot
Copy link
Contributor

@july2993, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn requested a review from seiya-annie November 10, 2020 11:10
@TomShawn TomShawn self-assigned this Nov 10, 2020
@TomShawn TomShawn added needs-cherry-pick-3.1 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Nov 10, 2020
TomShawn
TomShawn approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2020
csuzhangxc and others added 2 commits November 11, 2020 10:08
@csuzhangxc @TomShawn
Update tidb-binlog/tidb-binlog-relay-log.md
e61de50 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@csuzhangxc
Update tidb-binlog-relay-log.md
86663ac
seiya-annie
seiya-annie reviewed Nov 11, 2020
View reviewed changes
Copy link

@seiya-annie seiya-annie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当一个relay log文件大小大于等于10M（默认）并且最后一个事务被完整写入后，Drainer 就会开始将数据写入到下一个 relay log 文件中。

@ti-srebot
Copy link
Contributor

@seiya-annie, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn merged commit 1b086bb into pingcap:master Nov 11, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Nov 11, 2020
@csuzhangxc @ti-srebot
cherry pick pingcap#4867 to release-3.0
bb8d32e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 11, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4869

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Nov 11, 2020
@csuzhangxc @ti-srebot
cherry pick pingcap#4867 to release-3.1
c0cab53 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 11, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4870

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Nov 11, 2020
@csuzhangxc @ti-srebot
cherry pick pingcap#4867 to release-4.0
fb4d34b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 11, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4871

TomShawn pushed a commit that referenced this pull request Nov 11, 2020
@ti-srebot @csuzhangxc
cherry pick #4867 to release-3.0 (#4869)
80c308c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
TomShawn pushed a commit that referenced this pull request Nov 11, 2020
@ti-srebot @csuzhangxc
cherry pick #4867 to release-3.1 (#4870)
3534cbf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
TomShawn pushed a commit that referenced this pull request Nov 11, 2020
@ti-srebot @csuzhangxc
cherry pick #4867 to release-4.0 (#4871)
df6d5f0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
@TomShawn TomShawn changed the title zh: refine TiDB-Binlog relay log tidb binlog: refine relay log description Nov 12, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 12, 2020
@TomShawn TomShawn mentioned this pull request Nov 12, 2020
Merged
9 tasks
This was referenced Nov 13, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 july2993 approved these changes

@TomShawn TomShawn TomShawn approved these changes

@seiya-annie seiya-annie seiya-annie approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csuzhangxc @ti-srebot @july2993 @TomShawn @seiya-annie