Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: add upgrading section #4499

Merged
merged 2 commits into from
Sep 14, 2020
Merged

cdc: add upgrading section #4499

merged 2 commits into from
Sep 14, 2020

Conversation

overvenus
Copy link
Member

Signed-off-by: Neil Shen overvenus@gmail.com

What is changed, added or deleted? (Required)

Add TiCDC upgrading section.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A
  • Other reference link(s): N/A

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@overvenus
cdc: add upgrading section
d64e2ef 
Signed-off-by: Neil Shen <overvenus@gmail.com>
TomShawn
TomShawn reviewed Sep 14, 2020
View reviewed changes
TomShawn
TomShawn reviewed Sep 14, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2020
@TomShawn TomShawn requested a review from amyangfei September 14, 2020 09:55
@TomShawn TomShawn self-assigned this Sep 14, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Sep 14, 2020
amyangfei
amyangfei reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@amyangfei,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn merged commit 49ace01 into pingcap:master Sep 14, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 14, 2020
@overvenus @ti-srebot
cherry pick pingcap#4499 to release-4.0
bf6f41c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 14, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4501

TomShawn pushed a commit that referenced this pull request Sep 14, 2020
@ti-srebot @overvenus
cherry pick #4499 to release-4.0 (#4501)
5f3cd80 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus deleted the cdc/upgrade branch September 14, 2020 10:24
@TomShawn TomShawn mentioned this pull request Sep 14, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 14, 2020
@ti-srebot ti-srebot mentioned this pull request Sep 21, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @ti-srebot @amyangfei @TomShawn