Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix an error in create sequence #4301

Merged
merged 1 commit into from
Aug 20, 2020
Merged

fix an error in create sequence #4301

merged 1 commit into from
Aug 20, 2020

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Aug 20, 2020

What is changed, added or deleted? (Required)

fix an error in example sql statement

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2020
@TomShawn TomShawn requested a review from AilinKid August 20, 2020 12:07
AilinKid
AilinKid reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@AilinKid,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn TomShawn self-requested a review August 20, 2020 12:08
@TomShawn TomShawn added needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. labels Aug 20, 2020
@TomShawn TomShawn merged commit 40a7eb0 into pingcap:master Aug 20, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 20, 2020
@glorv @ti-srebot
cherry pick pingcap#4301 to release-4.0
c310200 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4305

@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 20, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Aug 20, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 20, 2020
Merged
9 tasks
ti-srebot added a commit that referenced this pull request Aug 20, 2020
@ti-srebot @glorv
fix an error in create sequence (#4301) (#4305)
45501c3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: glorv <glorvs@163.com>
@ti-srebot ti-srebot mentioned this pull request Aug 25, 2020
Merged
9 tasks
@glorv glorv deleted the patch-1 branch June 21, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@Joyinqin Joyinqin

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glorv @ti-srebot @Joyinqin @AilinKid @TomShawn