ticdc: update pulsar sink #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
PTAL @TomShawn @amyangfei |
TomShawn
added
needs-cherry-pick-4.0
size/medium
|
@amyangfei, @TomShawn, PTAL. |
amyangfei
reviewed
Aug 23, 2020
| @@ -111,64 +111,98 @@ Info: {"sink-uri":"mysql://root:123456@127.0.0.1:3306/","opts":{},"create-time": | |||
| ``` | |||
|
|
|||
| - `--changefeed-id`: 同步任务的 ID，格式需要符合正则表达式 `^[a-zA-Z0-9]+(\-[a-zA-Z0-9]+)*$`。如果不指定该 ID，TiCDC 会自动生成一个 UUID（version 4 格式）作为 ID。 | |||
| - `--sink-uri`: 同步任务下游的地址，需要按照以下格式进行配置，目前 scheme 支持 `mysql`/`tidb`/`kafka`。 | |||
| - `--sink-uri`: 同步任务下游的地址，需要按照以下格式进行配置，目前 scheme 支持 `mysql`/`tidb`/`kafka`/`pulsar`。 | |||
There was a problem hiding this comment.
mysql/tidb/pulsar 同样支持 mysql+ssl/tidb+ssl/pulsar+ssl，是否需要也在文档里写出
There was a problem hiding this comment.
我觉得没必要，因为 SSL/TLS 开启与否在于 URI 中的参数，而不是 scheme。
There was a problem hiding this comment.
那代码里 +ssl 的存在也没有意义了，现阶段 scheme 中的 +ssl 在代码里只是标识，不做检查
TomShawn
added
status/require-change
|
@overvenus, please update your pull request. |
|
@amyangfei,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack). |
TomShawn
reviewed
Aug 27, 2020
ti-srebot
pushed a commit
to ti-srebot/docs-cn
that referenced
this pull request
Aug 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
|
cherry pick to release-4.0 in PR #4359 |
ti-srebot
added a commit
that referenced
this pull request
Aug 27, 2020
9 tasks
TomShawn
added
translation/done
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update the Apache Pulsar sink configuration.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?