Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: update configure about backslash #4068

Merged
merged 2 commits into from
Aug 5, 2020
Merged

lightning: update configure about backslash #4068

merged 2 commits into from
Aug 5, 2020

Conversation

3pointer
Copy link
Contributor

What is changed, added or deleted? (Required)

Add more details about backslash configuration. or some users may confuse.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn added needs-cherry-pick-3.1 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Jul 28, 2020
TomShawn
TomShawn approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
@TomShawn
Copy link
Contributor

@3pointer Please also involve a technical review.

@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Aug 5, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 18f35d3 into pingcap:master Aug 5, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 5, 2020
@3pointer @ti-srebot
cherry pick pingcap#4068 to release-3.0
424b61b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4206

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 5, 2020
@3pointer @ti-srebot
cherry pick pingcap#4068 to release-3.1
17035e0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4207

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 5, 2020
@3pointer @ti-srebot
cherry pick pingcap#4068 to release-4.0
2af4012 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4208

ti-srebot added a commit that referenced this pull request Aug 6, 2020
@ti-srebot @3pointer @TomShawn
lightning: update configure about backslash (#4068) (#4207)
955c412 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
ti-srebot added a commit that referenced this pull request Aug 6, 2020
@ti-srebot @3pointer @TomShawn
lightning: update configure about backslash (#4068) (#4206)
a427413 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
ti-srebot added a commit that referenced this pull request Aug 6, 2020
@ti-srebot @3pointer @TomShawn
lightning: update configure about backslash (#4068) (#4208)
f615fa8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin Joyinqin mentioned this pull request Aug 8, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 10, 2020
This was referenced Aug 12, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees

@Joyinqin Joyinqin

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@3pointer @TomShawn @ti-srebot @Joyinqin