Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'tiup cluster edit-config' documentation #4000

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Update 'tiup cluster edit-config' documentation #4000

merged 1 commit into from
Jul 20, 2020

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Jul 20, 2020

Signed-off-by: Lonng heng@lonng.org

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@lonng
Update 'tiup cluster edit-config' documentation
b5628e0 
Signed-off-by: Lonng <heng@lonng.org>
@lonng
Copy link
Contributor Author

lonng commented Jul 20, 2020

@july2993 PTAL

@lonng lonng mentioned this pull request Jul 20, 2020
Merged
july2993
july2993 reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@july2993,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@coocood
Copy link
Member

coocood commented Jul 20, 2020

LGTM

@ti-srebot
Copy link
Contributor

@coocood,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. status/can-merge Indicates a PR has been approved by a committer. labels Jul 20, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lonng merge failed.

@TomShawn TomShawn merged commit abcf5f8 into pingcap:master Jul 20, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 20, 2020
@lonng @ti-srebot
cherry pick pingcap#4000 to release-4.0
a6e55b6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 20, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4002

TomShawn pushed a commit that referenced this pull request Jul 20, 2020
@ti-srebot @lonng
cherry pick #4000 to release-4.0 (#4002)
4c0b550 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Lonng <heng@lonng.org>
@TomShawn TomShawn self-assigned this Aug 12, 2020
@TomShawn TomShawn mentioned this pull request Aug 13, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 13, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 13, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 july2993 left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lonng @ti-srebot @coocood @july2993 @TomShawn