Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-config: remove useless note #3982

Merged
merged 1 commit into from
Jul 17, 2020
Merged

tidb-config: remove useless note #3982

merged 1 commit into from
Jul 17, 2020

Conversation

XuHuaiyu
Copy link
Contributor

What is changed, added or deleted? (Required)

Delete useless note since we've finished the test for the feature.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

SunRunAway
SunRunAway reviewed Jul 17, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@SunRunAway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ran-huang ran-huang self-requested a review July 17, 2020 02:59
@ran-huang ran-huang added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jul 17, 2020
@ran-huang ran-huang self-assigned this Jul 17, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@ran-huang ran-huang changed the title remove useless note tidb-config: remove useless note Jul 17, 2020
@ran-huang ran-huang merged commit 59dcee7 into pingcap:master Jul 17, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 17, 2020
@XuHuaiyu @ti-srebot
cherry pick pingcap#3982 to release-4.0
cfc9ad5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3983

ran-huang pushed a commit that referenced this pull request Jul 17, 2020
@ti-srebot @XuHuaiyu
cherry pick #3982 to release-4.0 (#3983)
a7dcabc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: HuaiyuXu <391585975@qq.com>
XuHuaiyu added a commit to XuHuaiyu/docs-cn that referenced this pull request Jul 21, 2020
@XuHuaiyu
revert pingcap#3961 pingcap#3982
9922aad
XuHuaiyu added a commit to XuHuaiyu/docs-cn that referenced this pull request Jul 21, 2020
@XuHuaiyu
revert pingcap#3961 pingcap#3982
b34734f
TomShawn added a commit that referenced this pull request Jul 21, 2020
@XuHuaiyu @TomShawn
Add a note for oom-action (#4014)
505a15d 
* revert #3961 #3982

* Update tidb-configuration-file.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 3, 2020
@ran-huang ran-huang mentioned this pull request Aug 3, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Aug 3, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@ran-huang ran-huang ran-huang approved these changes

Assignees

@ran-huang ran-huang

Labels
status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuHuaiyu @ti-srebot @SunRunAway @ran-huang