Skip to content

*: add more doc for slow log #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Sep 10, 2020
Merged

*: add more doc for slow log #3791

merged 45 commits into from
Sep 10, 2020

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Jun 24, 2020 •
edited
Loading

Signed-off-by: crazycs520 crazycs520@gmail.com

What is changed, added or deleted? (Required)

As title said.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@crazycs520
*: add more doc for slow log
e178553 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@yikeke yikeke requested review from TomShawn and zz-jason June 24, 2020 09:31
@yikeke yikeke added needs-cherry-pick-4.0 translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 24, 2020
@ti-srebot
Copy link
Contributor

@zz-jason, @TomShawn, PTAL.

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. size/medium Changes of a medium size. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 28, 2020
@TomShawn TomShawn self-assigned this Jun 28, 2020
@ti-srebot
Copy link
Contributor

@zz-jason, @TomShawn, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@zz-jason, @TomShawn, PTAL.

zz-jason
zz-jason reviewed Jul 7, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

@zz-jason, @TomShawn, PTAL.

crazycs520 and others added 5 commits July 9, 2020 17:29
@crazycs520 @zz-jason
Update tidb-specific-system-variables.md
9c20d16 
Co-authored-by: Zhang Jian <zjsariel@gmail.com>
@crazycs520 @zz-jason
Update tidb-specific-system-variables.md
4d75f34 
Co-authored-by: Zhang Jian <zjsariel@gmail.com>
@crazycs520
Merge branch 'master' into add-more-doc
c587737
@crazycs520
address comment
a1c0865 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Merge branch 'master' into add-more-doc
cb73e67
@ti-srebot
Copy link
Contributor

@zz-jason, @TomShawn, PTAL.

@ti-srebot
Copy link
Contributor

@zz-jason, @TomShawn, PTAL.

@crazycs520
update doc
691dcd2 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Merge branch 'master' into add-more-doc
a22897f
TomShawn
TomShawn reviewed Jul 14, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 14, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 14, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 14, 2020
View reviewed changes
@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/require-change Needs the author to address comments. labels Sep 3, 2020
@ti-srebot
Copy link
Contributor

@zz-jason, @TomShawn, @breeswish, @tangenta, PTAL.

@ti-srebot
Copy link
Contributor

@crazycs520, please update your pull request.

@ti-srebot
Copy link
Contributor

@zz-jason, @TomShawn, @breeswish, @tangenta, PTAL.

@ti-srebot
Copy link
Contributor

@crazycs520, please update your pull request.

@ti-srebot
Copy link
Contributor

@zz-jason, @TomShawn, @breeswish, @tangenta, PTAL.

@ti-srebot
Copy link
Contributor

@crazycs520, please update your pull request.

@ti-srebot
Copy link
Contributor

No updates for a long time, close PR.

crazycs520 and others added 3 commits September 10, 2020 11:15
@crazycs520
Merge branch 'master' into add-more-doc
d7cc293
@crazycs520 @TomShawn
Update system-variables.md
2534148 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@crazycs520 @TomShawn
Update system-variables.md
e7b1a8a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@crazycs520
Copy link
Contributor Author

@TomShawn PTAL

TomShawn
TomShawn reviewed Sep 10, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 10, 2020
@crazycs520 @TomShawn
Update system-variables.md
701610b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn merged commit d27dedd into pingcap:master Sep 10, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 10, 2020
@crazycs520 @ti-srebot
cherry pick pingcap#3791 to release-4.0
2944e03 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 10, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4468

TomShawn pushed a commit that referenced this pull request Sep 10, 2020
@ti-srebot @crazycs520
cherry pick #3791 to release-4.0 (#4468)
f672886 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: crazycs <crazycs520@gmail.com>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 11, 2020
@TomShawn TomShawn mentioned this pull request Sep 11, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Sep 21, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@breezewish breezewish breezewish approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

+2 more reviewers

@zz-jason zz-jason zz-jason left review comments

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@TomShawn TomShawn

Labels
size/medium Changes of a medium size. status/LGT2 Indicates that a PR has LGTM 2. status/require-change Needs the author to address comments. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@crazycs520 @ti-srebot @TomShawn @breezewish @zz-jason @tangenta @yikeke