Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column description for some system tables #3518

Merged
merged 11 commits into from
Jun 15, 2020
Merged

Add column description for some system tables #3518

merged 11 commits into from
Jun 15, 2020

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs crazycs520@gmail.com

What is changed, added or deleted? (Required)

As title said.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn self-requested a review June 7, 2020 04:40
@TomShawn TomShawn self-assigned this Jun 7, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 7, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jun 7, 2020

@crazycs520 Please involve a technical review.

djshow832
djshow832 reviewed Jun 12, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Update system-tables/system-table-information-schema.md
4a6844b
@crazycs520
fix lint
f890551 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

@TomShawn PTAL

TomShawn
TomShawn approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 6de3a6c into pingcap:master Jun 15, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 15, 2020
@crazycs520 @ti-srebot
cherry pick pingcap#3518 to release-4.0
98736b8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3669

TomShawn pushed a commit that referenced this pull request Jun 16, 2020
@ti-srebot @crazycs520
cherry pick #3518 to release-4.0 (#3669)
9fed4e1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: crazycs <crazycs520@gmail.com>
@yikeke yikeke added the size/medium Changes of a medium size. label Jun 19, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 16, 2020
@TomShawn TomShawn mentioned this pull request Jul 16, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crazycs520 @TomShawn @ti-srebot @djshow832 @yikeke